Fix label click scrolling to top
What does this MR do?
This MR fixes an issue where clicking on labels scrolls to the top. It was added in this commit in order to get checkboxes working in the dropdown.
Screenshots
It works!
Issue boards | Issue |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Closes #61246 (closed)
Merge request reports
Activity
changed milestone to %Backlog
2 Warnings You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, ~Documentation, QA labels.This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/gl_dropdown.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/gl_dropdown.js'
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Donald Cook ( @donaldcook
)Tim Zallmann ( @timzallmann
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added regression regression:11.10 regression:11.11 labels
@fatihacet could you review and merge this very small MR which fixes an annoying regression? Thank you!
assigned to @fatihacet
enabled an automatic merge when the pipeline for aef781c1 succeeds
Thanks @pslaughter. Enabled MWPS
added 22 commits
-
aef781c1...202e5251 - 21 commits from branch
master
- c9c7fa7b - Fix label click scrolling to top
-
aef781c1...202e5251 - 21 commits from branch
enabled an automatic merge when the pipeline for c9c7fa7b succeeds
@pslaughter
review-deploy
issue is known and it is safe to merge this with a broken pipeline.I will merge this right away.
However, the milestone should be 12.0, no?
changed milestone to %12.0
mentioned in commit 92b06c13
I changed the milestone to 12.0.
Thanks! It must have just copied over form the issue and I overlooked it
.I'm going to add the ~"Pick into 11.11" and ~"Pick into 11.10" since this regression affects those versions and it's pretty small.
Edited by Paul Slaughtermentioned in issue gitlab-org/release/tasks#801 (closed)
Automatically picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29405, will merge into
11-11-stable
ready for11.11.3
.mentioned in commit cfac448b
mentioned in merge request !29405 (merged)
mentioned in issue gitlab-org/release/tasks#804 (closed)
mentioned in merge request !29500 (merged)
Automatically picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30067, will merge into
11-10-stable
ready for11.10.7
.mentioned in commit 2fd5622e
mentioned in merge request !30067 (merged)
removed [deprecated] Accepting merge requests label