Fix connection to Tiller error while uninstalling
What does this MR do?
Make sure the configmap (with refreshed cert) is loaded for the uninstall pod.
Both the install-<app>
and uninstall-<app>
pods loads the
values-content-configuration-<app>
configmap into the pod
(see #volume_specification
). This configmap contains the cert
necessary to connect to Tiller. The cert though is only valid for 30
minutes.
So this fixes the bug where the configmap (when uninstalling) should be updated as well.
Q: How does the configmap have updated certs?
A: #config_map_resource
calls #files
which then calls #helm_cert
. #helm_cert
will issue a new cert valid for the next 30 minutes.
Closes #62713 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %11.11
added Category:Kubernetes Management devopsconfigure [DEPRECATED] regression regression:11.1 regression:11.11 typebug + 1 deleted label
marked the checklist item Changelog entry as completed
added 1 commit
- e553192f - Fix connection to Tiller error while uninstalling
@tigerwnz Can I please get your review on this MR ?
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Patrick Bajao ( @patrickbajao
)Douglas Barbosa Alexandre ( @dbalexandre
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- c7d50ddf - Fix connection to Tiller error while uninstalling
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
Thanks @tkuah for this quick diagnosis and bug fix!!!
Looks good to me @tkuah!
removed regression:11.1 label
@dbalexandre Can you please review this ~bug fix MR ?
Edited by Thong Kuahassigned to @dbalexandre and unassigned @tkuah
enabled an automatic merge when the pipeline for c7d50ddf succeeds
mentioned in issue gitlab-org/release/tasks#801 (closed)
Automatically picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29405, will merge into
11-11-stable
ready for11.11.3
.mentioned in commit f7f310e7
mentioned in merge request !29405 (merged)
mentioned in issue gitlab-org/release/tasks#804 (closed)
added groupconfigure [DEPRECATED] label
added groupenvironments label and removed groupconfigure [DEPRECATED] label