Skip to content
Snippets Groups Projects

Remove extraneous DiffNote#supports_suggestion? calls

All threads resolved!

What does this MR do?

This MR removes extra #supports_suggestion? method calls from DiffNote, as we do similar checks at suggestion create/edit. Calling this method here is superfluous and costly, as it's implicated as a source of quite a bit of Gitaly traffic.

Addresses #58297 (closed)

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kerri Miller added 127 commits

    added 127 commits

    • 36965b4e...c90e6943 - 125 commits from branch master
    • 8bb0449c - Lock suggestions_filter_enabled as true
    • cbd42c81 - Extend #parse to accept a suggestions_filter_enabled param

    Compare with previous version

  • Kerri Miller changed the description

    changed the description

  • Kerri Miller added 2 commits

    added 2 commits

    • de76e0ab - Remove 2nd stub expectation of #last_diff_file
    • 5ec48660 - Update spec param expectations

    Compare with previous version

  • Oswaldo Ferreira mentioned in merge request !25408 (merged)

    mentioned in merge request !25408 (merged)

  • Kerri Miller changed title from WIP: Remove extraneous #banzai_render_context to WIP: Remove extraneous DiffNote#supports_suggestion? calls

    changed title from WIP: Remove extraneous #banzai_render_context to WIP: Remove extraneous DiffNote#supports_suggestion? calls

  • Kerri Miller changed the description

    changed the description

  • Kerri Miller resolved all discussions

    resolved all discussions

  • Kerri Miller added 1 commit

    added 1 commit

    Compare with previous version

  • Kerri Miller marked the checklist item Changelog entry as completed

    marked the checklist item Changelog entry as completed

  • Kerri Miller marked the checklist item Code review guidelines as completed

    marked the checklist item Code review guidelines as completed

  • Kerri Miller marked the checklist item Merge request performance guidelines as completed

    marked the checklist item Merge request performance guidelines as completed

  • Kerri Miller marked the checklist item Style guides as completed

    marked the checklist item Style guides as completed

  • Kerri Miller changed the description

    changed the description

  • Kerri Miller added 214 commits

    added 214 commits

    • e0878e64...675b8d45 - 209 commits from branch master
    • f44eba8c - Lock suggestions_filter_enabled as true
    • 0c11d413 - Extend #parse to accept a suggestions_filter_enabled param
    • 1ffd03a1 - Remove 2nd stub expectation of #last_diff_file
    • e227ab8f - Update spec param expectations
    • 7e268d04 - Add changelog

    Compare with previous version

  • Kerri Miller added 1 commit

    added 1 commit

    Compare with previous version

  • Kerri Miller
  • Kerri Miller unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Kerri Miller added 4 commits

    added 4 commits

    • fb3d40cb - Extend #parse to accept a suggestions_filter_enabled param
    • bd624741 - Remove 2nd stub expectation of #last_diff_file
    • 732a89ce - Update spec param expectations
    • 9994a5c1 - Add changelog entry

    Compare with previous version

  • Kerri Miller resolved all discussions

    resolved all discussions

  • Kerri Miller changed the description

    changed the description

  • assigned to @oswaldo

  • Oswaldo Ferreira
  • Oswaldo Ferreira
  • Kerri Miller resolved all discussions

    resolved all discussions

  • mentioned in issue #62887 (moved)

  • Kerri Miller resolved all discussions

    resolved all discussions

  • Author Maintainer

    @dzaporozhets Reviewed by @oswaldo, looks ready for a review-and-merge.

  • Dmytro Zaporozhets (DZ) approved this merge request

    approved this merge request

  • mentioned in commit 96e2ff69

  • added typebug label

  • Stan Hu mentioned in merge request gitlab!18240 (closed)

    mentioned in merge request gitlab!18240 (closed)

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • Please register or sign in to reply
    Loading