Remove extraneous DiffNote#supports_suggestion? calls
What does this MR do?
This MR removes extra #supports_suggestion?
method calls from DiffNote
, as we do similar checks at suggestion create/edit. Calling this method here is superfluous and costly, as it's implicated as a source of quite a bit of Gitaly traffic.
Addresses #58297 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.0
1 Warning fb3d40cb: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Felipe Artur ( @felipe_artur
)Dmitriy 'DZ' Zaporozhets ( @dzaporozhets
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Kerri Miller
added 127 commits
-
36965b4e...c90e6943 - 125 commits from branch
master
- 8bb0449c - Lock suggestions_filter_enabled as true
- cbd42c81 - Extend #parse to accept a suggestions_filter_enabled param
-
36965b4e...c90e6943 - 125 commits from branch
added 2 commits
mentioned in merge request !25408 (merged)
marked the checklist item Changelog entry as completed
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
added 214 commits
Toggle commit list- Resolved by Kerri Miller
assigned to @oswaldo
- Resolved by Kerri Miller
- Resolved by Kerri Miller
mentioned in issue #62887 (moved)
assigned to @dzaporozhets
@dzaporozhets Reviewed by @oswaldo, looks ready for a review-and-merge.
@kerrizor thanks, LGTM!
mentioned in commit 96e2ff69
mentioned in issue gitlab-org/release/tasks#801 (closed)
added typebug label
mentioned in merge request gitlab!18240 (closed)
added Category:Code Review Workflow groupcode review labels and removed groupsource code label