Skip to content
Snippets Groups Projects

Remove extraneous DiffNote#supports_suggestion? calls

What does this MR do?

This MR removes extra #supports_suggestion? method calls from DiffNote, as we do similar checks at suggestion create/edit. Calling this method here is superfluous and costly, as it's implicated as a source of quite a bit of Gitaly traffic.

Addresses #58297 (closed)

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Pipeline #64919212 passed with warnings

Pipeline passed with warnings for 9994a5c1 on 58297-remove-extraneous-gitaly-calls-from-md-rendering

Test coverage 75.95% (-0.05%) from 2 jobs

Merged by Dmytro Zaporozhets (DZ)Dmytro Zaporozhets (DZ) 5 years ago (Jun 7, 2019 10:13am UTC)

Loading

Pipeline #65171911 failed

Pipeline failed for 96e2ff69 on master

Test coverage 54.61% (-0.05%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading