Fix OmniAuth OAuth2Generic strategy not loading
In https://github.com/rails/rails/commit/83b767ce, Rails 5.1 removed
support for using a String
to specify a middleware. When the
strategy_class
argument is passed from the GitLab YAML config to Devise,
Devise passes the string value straight through to Rails, and GitLab
would crash with a NoMethodError
inside ActionDispatch::MiddlewareStack
.
To make this OmniAuth strategy work again, we normalize the arguments by converting the strategy_class value into an actual Class.
Merge request reports
Activity
added 1 commit
- 9c273c71 - Fix OmniAuth OAuth2Generic strategy not loading
changed milestone to %11.11
assigned to @dbalexandre and unassigned @stanhu
mentioned in issue #62216 (closed)
added 1 commit
- 9f5b59a1 - Fix OmniAuth OAuth2Generic strategy not loading
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Thong Kuah ( @tkuah
)Dmitriy 'DZ' Zaporozhets ( @dzaporozhets
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Stan Hu
Thanks, @stanhu! LGTM, just one minor comment feel free to ignore.
assigned to @stanhu and unassigned @dbalexandre
added 1 commit
- bf8f4c13 - Fix OmniAuth OAuth2Generic strategy not loading
assigned to @dbalexandre and unassigned @stanhu
added Manage [DEPRECATED] priority2 severity1 labels
enabled an automatic merge when the pipeline for bf8f4c13 succeeds
Thanks, @stanhu! MWPS
mentioned in commit 7b5cc7b4
mentioned in issue omnibus-gitlab#4360 (closed)
Automatically picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28679, will merge into
11-11-stable
ready for11.11.2
.mentioned in commit c416e630
mentioned in merge request !28679 (merged)
mentioned in issue gitlab-org/release/tasks#799 (closed)
mentioned in issue gitlab-org/release/tasks#800 (closed)
mentioned in issue gitlab-org/release/tasks#804 (closed)
added typebug label
added devopsmanage label
mentioned in merge request gitlab!19891 (merged)