Skip to content
Snippets Groups Projects

Fix OmniAuth OAuth2Generic strategy not loading

Merged Stan Hu requested to merge sh-fix-omniauth-generic-strategy into master
All threads resolved!

In https://github.com/rails/rails/commit/83b767ce, Rails 5.1 removed support for using a String to specify a middleware. When the strategy_class argument is passed from the GitLab YAML config to Devise, Devise passes the string value straight through to Rails, and GitLab would crash with a NoMethodError inside ActionDispatch::MiddlewareStack.

To make this OmniAuth strategy work again, we normalize the arguments by converting the strategy_class value into an actual Class.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62216

Edited by Stan Hu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks, @stanhu! LGTM, just one minor comment feel free to ignore.

  • assigned to @stanhu and unassigned @dbalexandre

  • Stan Hu added 1 commit

    added 1 commit

    • bf8f4c13 - Fix OmniAuth OAuth2Generic strategy not loading

    Compare with previous version

  • Stan Hu resolved all discussions

    resolved all discussions

  • Stan Hu assigned to @dbalexandre and unassigned @stanhu

    assigned to @dbalexandre and unassigned @stanhu

  • Douglas Barbosa Alexandre approved this merge request

    approved this merge request

  • Douglas Barbosa Alexandre enabled an automatic merge when the pipeline for bf8f4c13 succeeds

    enabled an automatic merge when the pipeline for bf8f4c13 succeeds

  • mentioned in commit 7b5cc7b4

  • Automatically picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28679, will merge into 11-11-stable ready for 11.11.2.

  • GitLab Release Tools Bot removed 1 deleted label

    removed 1 deleted label

  • mentioned in commit c416e630

  • mentioned in merge request !28679 (merged)

  • added typebug label

  • Stan Hu mentioned in merge request gitlab!19891 (merged)

    mentioned in merge request gitlab!19891 (merged)

  • Please register or sign in to reply
    Loading