Update SAST.gitlab-ci.yml - Add SAST_GITLEAKS_ENTROPY_LEVEL
What does this MR do?
Properly propagates ENV variable SAST_GITLEAKS_ENTROPY_LEVEL
within SAST CI template.
This bug prevented the variable to be passed to the child containers executed through the
sast
docker-in-docker context, causing the variable to be ignored. In effect, this prevents
users from configuring their entropy detection
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/62179
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added devopssecure typebug + 1 deleted label
assigned to @fcatteau
added 1 commit
- 31e181f8 - Update SAST.gitlab-ci.yml - Add SAST_GITLEAKS_ENTROPY_LEVEL
marked the checklist item Changelog entry as completed
changed milestone to %12.0
2 Warnings You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, ~Documentation, QA labels.31e181f8: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Heinrich Lee Yu ( @engwan
)Bob Van Landuyt ( @reprazent
)Generated by
Dangerassigned to @ayufan
marked the checklist item Code review guidelines as completed
marked the checklist item Style guides as completed
marked the checklist item Separation of EE specific content as completed
mentioned in commit 2ae642f8
Automatically picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28679, will merge into
11-11-stable
ready for11.11.2
.mentioned in commit 672941ed
mentioned in merge request !28679 (merged)
mentioned in issue gitlab-org/release/tasks#799 (closed)
mentioned in issue gitlab-org/release/tasks#800 (closed)
mentioned in issue gitlab-org/release/tasks#804 (closed)
QA'd againstsecrets
test project using included SAST template: https://gitlab.com/gitlab-org/security-products/tests/secrets/-/jobs/229264120