Skip to content
Snippets Groups Projects

Use a path for the related merge requests endpoint

Merged Stan Hu requested to merge sh-fix-related-merge-requests-path into master
All threads resolved!

Hosts using a non-standard configuration may have a different hostname/port/scheme than what may be configured on the GitLab server. While expose_url should generate a proper URL, there are cases where it may not work. Since we don't need the full URL, we can use the relative path.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61280

Edited by Stan Hu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rémy Coutable
  • Rémy Coutable
  • @stanhu Thanks! I left small suggestions for the specs.

  • Rémy Coutable assigned to @stanhu and unassigned @rymai

    assigned to @stanhu and unassigned @rymai

  • Stan Hu added 1 commit

    added 1 commit

    • 949312d9 - Apply suggestion to spec/lib/api/helpers/related_resources_helpers_spec.rb

    Compare with previous version

  • Stan Hu added 1 commit

    added 1 commit

    • e6eae11c - Apply suggestion to spec/lib/api/helpers/related_resources_helpers_spec.rb

    Compare with previous version

  • Stan Hu added 34 commits

    added 34 commits

    Compare with previous version

  • Stan Hu added 1 commit

    added 1 commit

    • 46a4cce6 - Apply suggestion to spec/lib/api/helpers/related_resources_helpers_spec.rb

    Compare with previous version

  • Stan Hu added 1 commit

    added 1 commit

    • a85b895d - Use a path for the related merge requests endpoint

    Compare with previous version

  • Stan Hu resolved all discussions

    resolved all discussions

  • assigned to @rymai

  • Stan Hu added 1 commit

    added 1 commit

    • 58c09eb7 - Use a path for the related merge requests endpoint

    Compare with previous version

  • Stan Hu mentioned in issue #61558 (closed)

    mentioned in issue #61558 (closed)

  • Stan Hu mentioned in issue #61433 (moved)

    mentioned in issue #61433 (moved)

  • @stanhu Thank you, looks good to me! :heart: :yellow_heart: :green_heart: :rocket:

  • Rémy Coutable approved this merge request

    approved this merge request

  • Rémy Coutable mentioned in commit ed823c35

    mentioned in commit ed823c35

  • Stan Hu mentioned in issue #60760 (closed)

    mentioned in issue #60760 (closed)

  • added typebug label

  • @stanhu This merge request could not automatically be picked into 11-10-stable for 11.10.6 and will need manual intervention. Please create a new MR targeting the source branch of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28991, and assign to release managers.

  • mentioned in merge request !28991 (merged)

  • Stan Hu mentioned in merge request !29058 (closed)

    mentioned in merge request !29058 (closed)

  • Author Owner
    Edited by Stan Hu
  • Stan Hu removed 1 deleted label

    removed 1 deleted label

  • Rémy Coutable mentioned in commit ad7dc610

    mentioned in commit ad7dc610

  • Please register or sign in to reply
    Loading