Use a path for the related merge requests endpoint
Hosts using a non-standard configuration may have a different hostname/port/scheme than what may be configured on the GitLab server. While expose_url should generate a proper URL, there are cases where it may not work. Since we don't need the full URL, we can use the relative path.
Merge request reports
Activity
changed milestone to %11.11
added Create [DEPRECATED] regression:10.x + 1 deleted label
added 1 commit
- b409bc9b - Use a path for the related merge requests endpoint
mentioned in issue #61280 (closed)
added 5 commits
-
b409bc9b...bd73925b - 4 commits from branch
master
- 0dfe603b - Use a path for the related merge requests endpoint
-
b409bc9b...bd73925b - 4 commits from branch
assigned to @rymai
unassigned @stanhu
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Sarah Groff Hennigh-Palermo ( @sarahghp
)Fatih Acet ( @fatihacet
)backend João Cunha ( @Alexand
)Ash McKenzie ( @ashmckenzie
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Stan Hu
- Resolved by Stan Hu
- Resolved by Stan Hu
@stanhu Thanks! I left small suggestions for the specs.
added 1 commit
- 949312d9 - Apply suggestion to spec/lib/api/helpers/related_resources_helpers_spec.rb
added 1 commit
- e6eae11c - Apply suggestion to spec/lib/api/helpers/related_resources_helpers_spec.rb
added 34 commits
-
e6eae11c...fb688545 - 33 commits from branch
master
- 62d00906 - Use a path for the related merge requests endpoint
-
e6eae11c...fb688545 - 33 commits from branch
added 1 commit
- 46a4cce6 - Apply suggestion to spec/lib/api/helpers/related_resources_helpers_spec.rb
added 1 commit
- a85b895d - Use a path for the related merge requests endpoint
assigned to @rymai
added 1 commit
- 58c09eb7 - Use a path for the related merge requests endpoint
mentioned in issue #61558 (closed)
mentioned in issue #61433 (moved)
@stanhu Thank you, looks good to me!
mentioned in commit ed823c35
mentioned in issue #60760 (closed)
mentioned in issue gitlab-org/release/tasks#780 (closed)
added typebug label
@stanhu This merge request could not automatically be picked into
11-10-stable
for11.10.6
and will need manual intervention. Please create a new MR targeting the source branch of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28991, and assign to release managers.mentioned in merge request !28991 (merged)
mentioned in merge request !29058 (closed)
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29058 should cover this for 11.10.
Edited by Stan Humentioned in commit ad7dc610
added devopscreate label