Skip to content

Omit max-count for diverging_commit_counts behind feature flag

John Cai requested to merge jc-omit-count-diverging-commits-max into master

What does this MR do?

part of: gitaly#1462 (closed)

Now that commit graphs are enabled in gc gitaly!1218 (merged), the --max-count argument shouldn't be necessary in most cases. However, before getting rid of it completely, we want to test this out behind a feature flag, as for very large repos we may still need --max-count (gitaly#1462 (comment 167371813))

This MR sets max_count to 0, which in Gitaly will result in omitting the --max-count flag:

https://gitlab.com/gitlab-org/gitaly/blob/master/internal/service/commit/count_diverging_commits.go#L53-54

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by John Cai

Merge request reports