Skip to content

Fix input group and action buttons in "set status" modal

What does this MR do?

This fixes some visual bugs affecting the Set status modal as can be seen on this screenshot:

Screen_Shot_2019-05-06_at_9.23.44_AM

1. The input add-ons look like they need more padding to match the input's height

To fix this, the markup has been updated to match what's recommended in Bootsrap's documentation and some padding has been added to the emojis dropdown toggle:

input_group_fix

2. On IE11 specifically, the buttons are flowing out of the modal

It appears this was caused by a margin-left: auto being applied to the first button in the footer, here's the original change: https://gitlab.com/gitlab-org/gitlab-ce/commit/070de825987ce103ac89059e8c743daaf857dc58#33f42d8ca8562857235369877b87ff6e2cc81729_23_42

This rule does not seem to be required anymore and has been removed altogether:

Screen_Shot_2019-05-06_at_3.00.30_PM

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Closes #61494 (closed)

Edited by Paul Gascou-Vaillancourt

Merge request reports