Disable method replacement in avatar loading
We've seen a significant performance penalty when using
BatchLoader#__replace_with!
. This defines methods on the batch loader
that proxy to the 'real' object using send. The alternative is
method_missing
, which is slower. However, we've noticed that
method_missing
can be faster if:
- The objects being loaded have a large interface.
- We don't call too many methods on the loaded object.
Avatar uploads meet both criteria above, so let's use the newly-released feature in https://github.com/exAspArk/batch-loader/pull/45.
Merge request reports
Activity
added 1 commit
- 78f0911f - Disable method replacement in avatar loading
changed milestone to %11.11
added bugperformance label
assigned to @smcgivern
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Mario de la Ossa ( @mdelaossa
)Michael Kozono ( @mkozono
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 25818bd7 - Disable method replacement in avatar loading
Thanks @stanhu!
added Plan [DEPRECATED] backend typebug labels
mentioned in commit c10d0091
mentioned in issue gitlab-org/release/tasks#778 (closed)
added devopsplan label