Skip to content

Upgrade letter_opener_web to support Rails 5.1

Peter Leitzen requested to merge pl-upgrade-letter_opener_web into master

What does this MR do?

Before this commit using /rails/letter_opener in development environment failed with:

ActionController::RoutingError - undefined method `before_filter' for LetterOpenerWeb::LettersController:Class
Did you mean?  before_action:
  actionpack (5.1.1) lib/action_dispatch/routing/route_set.rb:45:in `rescue in controller'
  actionpack (5.1.1) lib/action_dispatch/routing/route_set.rb:43:in `controller'
  actionpack (5.1.1) lib/action_dispatch/routing/route_set.rb:29:in `serve'
  actionpack (5.1.1) lib/action_dispatch/journey/router.rb:46:in `block in serve'
  actionpack (5.1.1) lib/action_dispatch/journey/router.rb:33:in `serve'
  actionpack (5.1.1) lib/action_dispatch/routing/route_set.rb:832:in `call'
  railties (5.1.1) lib/rails/engine.rb:522:in `call'
  railties (5.1.1) lib/rails/railtie.rb:185:in `method_missing'
  actionpack (5.1.1) lib/action_dispatch/routing/mapper.rb:17:in `block in <class:Constraints>'
  actionpack (5.1.1) lib/action_dispatch/routing/mapper.rb:46:in `serve'
  actionpack (5.1.1) lib/action_dispatch/journey/router.rb:46:in `block in serve'
  actionpack (5.1.1) lib/action_dispatch/journey/router.rb:33:in `serve'
  actionpack (5.1.1) lib/action_dispatch/routing/route_set.rb:832:in `call'

See https://github.com/fgrehm/letter_opener_web/issues/68

This commit upgrades letter_opener_web to 1.3.4 so Rails 5.1 is supported.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports