Skip to content

Externalize left sidebar strings

Victor Wu requested to merge (removed):patch-58 into master

What does this MR do?

  • Replaces https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27667.
  • Externalize left sidebar strings
  • As shown in the screenshots on my local branch, the strings are correctly displayed.
  • Collapse sidebar appears to be already externalized from another location so it is picking up a translation.
  • Close sidebar appears to be new, so it is added in the gitlab.pot file.

Screen_Shot_2019-04-25_at_09.30.59

Screen_Shot_2019-04-25_at_09.31.11

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Victor Wu

Merge request reports