Skip to content

Generate valid atom for issue feeds

Devin Sylva requested to merge 26150_generate_valid_atom into master

What does this MR do?

Corrects output of atom feeds to conform to the atom spec

Addresses this issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/26150

This change makes RSS feeds comply with the standard specified in the feed. The XML output by the feeds was a combination of RSS and direct use of internal schema names. However, at the top of the XML, it specifies Atom schema, so feed readers are trying to parse it as Atom. In most cases, they will ignore the extra fields, but since it was using description (from the RSS spec) instead of content (from Atom), only the issue title was showing up in feed readers.

The risk of this change is that if anyone has custom automated written to use the broken format, those scripts will break when the field names are changed.

It would also be nice to know why the wrong fields were originally used. Was it an oversight? Or was there a deliberate reason behind it?

As an alternative to introducing this risk, https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27652 is a minimal optional solution. Only one or the other of these MR's should be accepted.

Edited by Devin Sylva

Merge request reports