Always return the deployment in the UpdateDeploymentService#execute method
What does this MR do?
There are few cases that deployment becomes nil https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/services/update_deployment_service.rb#L25-26, but we should be consistent and always return the deployment in the execute method. The changes introduced here always return the deployment even when something went wrong while updating the environment. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11124.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team