Skip to content
Snippets Groups Projects

Process at most 4 pipelines during push

Merged Kamil Trzciński requested to merge limit-amount-of-created-pipelines into master
All threads resolved!

What does this MR do?

This limits the number of pipelines that we create in a single push to 4.

This is to prevent doing git push --all or git push --mirror to create a ton of Pipelines.

This does not prevent every possible abusive scenario, but rather prevent mistakes when dealing with git repository.

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/51401

Does this MR meet the acceptance criteria?

Conformity

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Grzegorz Bizon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 2f79772d - Process at most 4 pipelines during push

    Compare with previous version

  • John Jarvis
  • added 1 commit

    • 680d2a71 - Process at most 4 pipelines during push

    Compare with previous version

  • added 1 commit

    • b6d1244b - Process at most 4 pipelines during push

    Compare with previous version

  • Bob Van Landuyt
  • assigned to @ayufan

  • Since it has a feature flag, I think we can pick it :smile:.

  • Bob Van Landuyt added feature flag + 1 deleted label

    added feature flag + 1 deleted label

  • 1 Warning
    :warning: This merge request is missing the ~Documentation label.
    1 Message
    :book: This merge request adds or changes files that require a review from the Technical Writing team.

    Documentation review

    The following files require a review from a technical writer:

    • doc/ci/yaml/README.md

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    backend Peter Leitzen (@splattael) Stan Hu (@stanhu)
    ~Documentation Achilleas Pipinellis (@axil)

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • added 1 commit

    • 2b9492a2 - Process at most 4 pipelines during push

    Compare with previous version

  • Grzegorz Bizon
  • Grzegorz Bizon
  • mentioned in issue #51401 (closed)

  • Bob Van Landuyt
  • Bob Van Landuyt approved this merge request

    approved this merge request

  • @grzesiek as you're already here, and there's some unresolved discussions you're involved in, would you mind taking the maintainer review?

  • assigned to @brendan

  • assigned to @ayufan

  • Grzegorz Bizon marked the checklist item Changelog entry as completed

    marked the checklist item Changelog entry as completed

  • Grzegorz Bizon marked the checklist item Code review guidelines as completed

    marked the checklist item Code review guidelines as completed

  • Grzegorz Bizon marked the checklist item Style guides as completed

    marked the checklist item Style guides as completed

  • Grzegorz Bizon resolved all discussions

    resolved all discussions

  • Grzegorz Bizon approved this merge request

    approved this merge request

  • Grzegorz Bizon mentioned in commit a97e039e

    mentioned in commit a97e039e

  • Kamil Trzciński changed milestone to %11.10

    changed milestone to %11.10

  • This merge request could not automatically be picked into 11-10-stable for 11.10.0-rc7 and will need manual intervention.

  • mentioned in merge request !27289 (merged)

  • This merge request could not automatically be picked into 11-10-stable for 11.10.0-rc7 and will need manual intervention.

  • This merge request could not automatically be picked into 11-10-stable for 11.10.0-rc7 and will need manual intervention.

  • Grzegorz Bizon mentioned in commit f3d1e553

    mentioned in commit f3d1e553

  • Kamil Trzciński mentioned in merge request !27308 (merged)

    mentioned in merge request !27308 (merged)

  • John Jarvis removed 1 deleted label

    removed 1 deleted label

  • If this cannot be reverted, ca we at least:

    A. Queue the pipelines and create them 4 at a time

    OR

    B. Make this configurable. Right now it's hardcoded ?!

    Edited by Mircea Danila Dumitrescu
  • mentioned in issue gitlab#350886

  • mentioned in merge request gitlab!81974 (merged)

  • Please register or sign in to reply
    Loading