Skip to content
Snippets Groups Projects

Document matching refs with an at-symbol

Merged Cody Mize requested to merge kingcody/gitlab-ce:docs/ci-refs-at-symbol into master
All threads resolved!

What does this MR do?

Document pattern matching refs that contain an at-symbol.

At-symbols are used to match a ref to a specific repository path. Currently this is done by string splitting the ref pattern on the at-symbol. In order to pattern match a literal @ you must use RE2's hex character code matching \x40.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Cody Mize

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @kingcody.

    I've suggested a minor edit, just to say the same thing with fewer words.

    @dosuken123, this look technically correct?

    Thanks all!

  • assigned to @kingcody

  • Evan Read changed milestone to %11.10

    changed milestone to %11.10

  • @kingcody Thanks. I left one question.

  • Cody Mize added 1 commit

    added 1 commit

    • 28a5b386 - Apply suggestion to doc/ci/yaml/README.md

    Compare with previous version

  • Cody Mize resolved all discussions

    resolved all discussions

  • Cody Mize added 1 commit

    added 1 commit

    Compare with previous version

  • Cody Mize changed the description

    changed the description

  • @dosuken123 If you're happy with the changes, now, let me know and I'll merge.

    Thanks @kingcody

  • assigned to @eread

  • Evan Read approved this merge request

    approved this merge request

  • merged

  • Evan Read mentioned in commit 6c56bf31

    mentioned in commit 6c56bf31

  • Author Contributor

    Thank you @dosuken123 and @eread for your time and reviews.

    Edited by Cody Mize
  • Please register or sign in to reply
    Loading