Download a folder from repository

What does this MR do?

This is based from the Community contribution MR from @kiameisomabes: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20604.

Add links to download a folder from repository in different formats (zip, tar.gz, tar.bz2, or tar).

Add GetArchiveRequest to git-archive params.

Modifies Git::Repository#archive_metadata to append path to ArchivePrefix so it'll not hit the cache of repository archive when it already exists.

gitlab-ee MR is created as ee_compat_check fails: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10533.

What are the relevant issue numbers?

#24704 (closed)

TODOs

• Update GITALY_SERVER_VERSION when version required gets released.
• Update GITLAB_WORKHORSE_VERSION when version required gets released.
• Update gitaly-proto gem when version required gets released.

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated via this MR
• Documentation reviewed by technical writer or follow-up review issue created
• Tests added for this feature/bug
• Tested in all supported browsers
• Conforms to the code review guidelines
• Conforms to the merge request performance guidelines
• Conforms to the style guides
• Conforms to the database guides
• Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
• Security reports checked/validated by reviewer

Closes #24704 (closed)

changed milestone to %11.10

added Community contribution Create [DEPRECATED] Deliverable backend coach will finish devopscreate frontend golang missed-deliverable missed:11.6 missed:11.8 missed:11.9 popular proposal priority3 release post item repository ~2975006 workflowin dev + 1 deleted label

changed the description

assigned to @patrickbajao

added 1 commit

• 44e8a0aa - Add changelog entry

Compare with previous version

mentioned in merge request gitlab-workhorse!375 (merged)

	1 Message
	This merge request adds or changes files that require a review from the Technical Writing team.

Documentation review

The following files require a review from a technical writer:

• doc/user/project/repository/img/download_source_code.png
• doc/user/project/repository/index.md

The review does not need to block merging this merge request. See the:

• DevOps stages for the appropriate technical writer for this review.
• Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Rubén Dávila (@rdavila)	Michael Kozono (@mkozono)
frontend	Adriel Santiago (@adrielsantiago)	Tim Zallmann (@timzallmann)
~Documentation		Evan Read (@eread)

Generated by Danger

changed title from WIP: Download a folder from repository (not complete repository or single files) to WIP: Download a folder from repository

mentioned in merge request !20604 (closed)

added 1 commit

• 02b54d02 - Download a folder from repository

Compare with previous version

marked the checklist item Update gitaly-proto gem when version required gets released. as completed

added 1 commit

• ad1cd5b0 - Download a folder from repository

Compare with previous version

changed the description

added 1 commit

• 439cb0fe - Make the dropdown match the design

Compare with previous version

added 1 commit

• 4aa0e1e9 - Make the dropdown match the design

Compare with previous version

Hi @nick.thomas, can you also please review this MR? Since you're reviewing the MR for gitlab-workhorse, I think it's also good if you review the backend part of this MR as well as it's related to it.

Also, what do you think about putting this behind a feature flag? The change in how we encode the send data header for git-archive and the new links?

Pipeline is red as some of the dependencies are still pointing to branches instead of releases. Thanks!

@patrickbajao I've tried running this locally against the gitaly and gitlab-workhorse branches, but I'm not seeing that it just gets the subdirectory in the archive :( . Is it currently working for you locally?

@nick.thomas Hmm it does work on my end. Just tested it again. Not sure if this will help but...

I'm using the GDK and before I run gdk run, I run gdk install to re-compile gitaly and workhorse. Both gitaly and gitlab-workhorse src are checked out under the branches specified in GITALY_SERVER_VERSION and GITLAB_WORKHORSE_VERSION when I do this. I don't think gdk install will pick up the branches automatically.

Running make gitlab-workhorse-update gitaly-update works for me too if my src aren't under the branches I need.

assigned to @nick.thomas