Skip to content

Fix race condition in ApplicationSettingImplementation.create_from_defaults

Rémy Coutable requested to merge 59162-fix-review-apps-initial-seeding into master

What does this MR do?

Fixes a race condition in ApplicationSettingImplementation.create_from_defaults.

This race condition could prevent Review Apps from being properly deployed/seeded.

What are the relevant issue numbers?

Closes #59162 (closed) (and potentially https://gitlab.com/gitlab-org/gitlab-ce/issues/59113 as well).

Does this MR meet the acceptance criteria?

Edited by Rémy Coutable

Merge request reports