Fix Auto DevOps QA Smoke test hidden banner
What does this MR do?
The banner is no longer being shown for empty repos since
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26024 . We could
have made this assertion after pushing the repo but this is not the kind
of thing that really needs to be in an integration or smoke test as it
is already tested in
spec/features/projects/show/user_interacts_with_auto_devops_banner_spec.rb
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
- [-] Changelog entry added, if necessary
- [-] Documentation created/updated via this MR
- [-] Documentation reviewed by technical writer or follow-up review issue created
- [-] Tests added for this feature/bug
- [-] Tested in all supported browsers
-
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides - [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
-
Security reports checked/validated by reviewer
Closes https://gitlab.com/gitlab-org/quality/nightly/issues/87
Merge request reports
Activity
added QA Quality backstage [DEPRECATED] + 1 deleted label
@ddavison the smoke test is failing for this MR (along with a few other ones) with this error:
1st Try error in ./qa/specs/features/browser_ui/7_configure/auto_devops/create_project_with_auto_devops_spec.rb:111: Fabrication of QA::Resource::Project using the API failed (400) with `{"message":{"base":["4:Deadline Exceeded"],"limit_reached":[]}}`.
Is this a known issue? What should we do about this?
- Resolved by Dan Davison
this looks great @DylanGriffith !
this seems to be a good fix, and this is still a valid smoke test verifying the tag.
one comment, then we can merge in!
Edited by Dan Davisonenabled an automatic merge when the pipeline for c5b54821 succeeds
Is this a known issue? What should we do about this?
https://gitlab.com/gitlab-org/gitlab-ce/issues/59113#note_151664433
mentioned in commit fbc49fa3
mentioned in merge request !26641 (merged)
changed milestone to %11.10
mentioned in issue gitlab-org/quality/canary#1 (closed)
mentioned in issue gitlab-org/release/tasks#744 (closed)
mentioned in merge request !27289 (merged)
mentioned in issue gitlab-org/release/retrospectives#17 (closed)
mentioned in issue gitlab-org/release/tasks#748 (closed)
It was labeled upon request: gitlab-org/quality/canary#1 (comment 160022903). Now that we know it's already in place, we may need to revisit the linked issue if it continues to be a problem.
added groupconfigure [DEPRECATED] label
added groupenvironments label and removed groupconfigure [DEPRECATED] label