Skip to content
Snippets Groups Projects

Fix Auto DevOps QA Smoke test hidden banner

All threads resolved!

What does this MR do?

The banner is no longer being shown for empty repos since https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26024 . We could have made this assertion after pushing the repo but this is not the kind of thing that really needs to be in an integration or smoke test as it is already tested in spec/features/projects/show/user_interacts_with_auto_devops_banner_spec.rb

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Closes https://gitlab.com/gitlab-org/quality/nightly/issues/87

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • this looks great @DylanGriffith !

    this seems to be a good fix, and this is still a valid smoke test verifying the tag.

    one comment, then we can merge in!

    Edited by Dan Davison
  • Dan Davison added 1 commit

    added 1 commit

    • c5b54821 - Fix Auto DevOps QA Smoke test hidden banner

    Compare with previous version

  • Dan Davison resolved all discussions

    resolved all discussions

  • Dan Davison approved this merge request

    approved this merge request

  • Dan Davison enabled an automatic merge when the pipeline for c5b54821 succeeds

    enabled an automatic merge when the pipeline for c5b54821 succeeds

  • Is this a known issue? What should we do about this?

    https://gitlab.com/gitlab-org/gitlab-ce/issues/59113#note_151664433

  • Dan Davison added 1 commit

    added 1 commit

    • 3f88bc98 - Fix Auto DevOps QA Smoke test hidden banner

    Compare with previous version

  • merged

  • Dan Davison mentioned in commit fbc49fa3

    mentioned in commit fbc49fa3

  • Dan Davison mentioned in merge request !26641 (merged)

    mentioned in merge request !26641 (merged)

  • Rémy Coutable changed milestone to %11.10

    changed milestone to %11.10

  • Dan Davison added 1 deleted label

    added 1 deleted label

  • This merge request could not automatically be picked into 11-10-stable for 11.10.0-rc7 and will need manual intervention.

  • mentioned in merge request !27289 (merged)

  • This merge request could not automatically be picked into 11-10-stable for 11.10.0-rc7 and will need manual intervention.

  • This merge request could not automatically be picked into 11-10-stable for 11.10.0-rc7 and will need manual intervention.

  • This merge request could not automatically be picked into 11-10-stable for 11.10.0-rc7 and will need manual intervention.

  • This merge request could not automatically be picked into 11-10-stable for 11.10.0-rc7 and will need manual intervention.

  • This merge request could not automatically be picked into 11-10-stable for 11.10.0-rc7 and will need manual intervention.

  • Not sure why this was labeled ~"Pick into 11.10" because it was already present in the stable branch.

  • Stan Hu removed 1 deleted label

    removed 1 deleted label

  • It was labeled upon request: gitlab-org/quality/canary#1 (comment 160022903). Now that we know it's already in place, we may need to revisit the linked issue if it continues to be a problem.

  • Please register or sign in to reply
    Loading