Skip to content
Snippets Groups Projects

Don't sanitize project names on project members page

All threads resolved!

What does this MR do?

It will remove the usage of sanitize_project_name(name) for project members page views.

What are the relevant issue numbers?

Fixes #58751 (closed) .

Does this MR meet the acceptance criteria?

Edited by Elias Werberich

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @bephinix thanks, one question!

  • assigned to @bephinix

  • added 1 commit

    • 83fb62d4 - Don't sanitize project names on project members page

    Compare with previous version

  • Elias Werberich resolved all discussions

    resolved all discussions

  • Author Contributor

    @smcgivern You are right. Without stripping all html tags it does not make much sense. I added tags: [].

  • Sean McGivern approved this merge request

    approved this merge request

  • Sean McGivern enabled an automatic merge when the pipeline for 83fb62d4 succeeds

    enabled an automatic merge when the pipeline for 83fb62d4 succeeds

  • Contributor

    @smcgivern/@bephinix it looks like there's a pipeline failure?

  • Author Contributor

    @rpaik I rebased ee port branch on ee/master and ported new commit for ce to ee. There are still a lot of conflicts. AFAIK I did the port how it is documented here.

    The other failing job was a timeout.

  • Author Contributor

    @rpaik Ok, I forgot to push the new ee commits. :face_palm: The failing mysql rspec job throws some strange errors.

  • Contributor

    @smcgivern can you help with the mysql error?

  • The failure there is https://gitlab.com/gitlab-org/gitlab-ce/issues/59747, which should be fixed in current master.

  • Sean McGivern canceled the automatic merge

    canceled the automatic merge

  • Sean McGivern mentioned in commit 5ddd4f0f

    mentioned in commit 5ddd4f0f

  • merged

  • Please register or sign in to reply
    Loading