Skip to content
Snippets Groups Projects

Don't cutoff letters in MR and Issue links

Merged gfyoung requested to merge (removed):related-mr-link-cutoff into master
All threads resolved!
Source Before After
https://gitlab.com/gitlab-org/gitlab-ce/issues/58231 before-one after-one
https://gitlab.com/gitlab-org/gitlab-ce/issues/58576 before-two after-two

The issue was observed on a large desktop screen with Windows 10, Chrome 72.0.3626.121 (64-bit).

This MR bumps up the line height for both .sortable-link and .mr-title-link in this case (currently, it is set by .item-body). The former affects the related issues section of an issue or MR. The latter affects the related MR's section.

Not sure if this is the best solution, but it's the one that worked for me after some tinkering.

Suggested Reviewers/Approvers/Mergers

@annabeldunstone @iamphill @ClemMakesApps

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Paul Slaughter
  • gfyoung added 1010 commits

    added 1010 commits

    Compare with previous version

  • Paul Slaughter resolved all discussions

    resolved all discussions

  • Thanks @gfyoung! Sorry for all the back and forth, but it did help uncover a part of our process that could have contributed more regressions. I really appreciate your patience over a few pixels! :muscle:

    @iamphill could you review and merge this very small MR please? Thank you! :bow:

  • Annabel Dunstone Gray approved this merge request

    approved this merge request

  • mentioned in commit a06f9a33

  • Thanks for taking over the merge @annabeldunstone! I pinged @iamphill by habit :smile:

  • Author Contributor

    @annabeldunstone @pslaughter : No worries! I appreciate the discussion.

  • mentioned in issue #61286 (moved)

  • mentioned in issue gitlab-ui#1143

  • Please register or sign in to reply
    Loading