Don't cutoff letters in MR and Issue links
Source | Before | After |
---|---|---|
https://gitlab.com/gitlab-org/gitlab-ce/issues/58231 | ||
https://gitlab.com/gitlab-org/gitlab-ce/issues/58576 |
The issue was observed on a large desktop screen with Windows 10, Chrome 72.0.3626.121 (64-bit).
This MR bumps up the line height for both .sortable-link
and .mr-title-link
in this case (currently, it is set by .item-body
). The former affects the related issues section of an issue or MR. The latter affects the related MR's section.
Not sure if this is the best solution, but it's the one that worked for me after some tinkering.
Suggested Reviewers/Approvers/Mergers
Merge request reports
Activity
added Community contribution label
@pslaughter can you help take a look?
Thanks @gfyoung for the contribution
added frontend label
assigned to @pslaughter
- Resolved by Paul Slaughter
I know this is not related to this MR, but what happened here:
I can't even press the right arrow to "scroll across". This was observed on the same machine that prompted this MR.
Edited by gfyoung
- Resolved by Paul Slaughter
Thanks for submitting this MR @gfyoung! I tried recreating this locally on a personal Windows machine and in Browserstack. Here's a screenshot of what I see on Windows 10 Chrome 72 on Browserstack:
No cutoff
What's interesting is that GitLab loads a different font based on your system fonts (to make it feel more naturally). I wondered if maybe your local system fonts somehow deviated from the norm, but the screenshot looked pretty similar just slightly off in size. I then tried changing the browser zoom from 100% to 110% and was able to recreate the screenshot in this MR description.
Could you check that your browser zoom is 100%
? If it is and you are still seeing the cut off, is it possible that your default system fonts have changed?
changed milestone to %11.10
@annabeldunstone, I'll go ahead and assign this to you for investigation. Thanks for the help!
assigned to @annabeldunstone
- Resolved by Annabel Dunstone Gray
I checked on Windows Chrome 73.0.3683.75 and do see the issue, although it's not quite as drastic as the screenshots in the description
@pslaughter I agree we should come up with a solution that will also fix the emoji clipping. Do you have any suggestions? I'll look into it a bit more while I'm still testing on this PC.
assigned to @pslaughter
- Resolved by gfyoung
- Resolved by gfyoung
added 1010 commits
-
511fc077...4488b592 - 1009 commits from branch
gitlab-org:master
- fb410bca - Don't cutoff letters in MR and Issue links
-
511fc077...4488b592 - 1009 commits from branch
assigned to @iamphill
assigned to @gfyoung
assigned to @annabeldunstone
mentioned in commit a06f9a33
Thanks for taking over the merge @annabeldunstone! I pinged @iamphill by habit
@annabeldunstone @pslaughter : No worries! I appreciate the discussion.
mentioned in issue gitlab-design#300 (closed)
mentioned in issue gitlab-org/release/tasks#731 (closed)
mentioned in issue #61286 (moved)
mentioned in issue gitlab-ui#1143