Skip to content

Remove TLD validation from cluster domain

Dylan Griffith requested to merge 57650-remove-tld-validation-from-cluster into master

What does this MR do?

This validation was introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24368 but it is undesirable for a couple of reasons:

  1. It may make sense for use cases in internal applications that this domain is not actually a valid TLD
  2. It also led to a regression because perfectly valid TLDs are not known by the validator we are using (eg. .live #57650 (closed)) . We could have updated the gem to fix that but I don't believe we actually want this validation anyway.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Closes #57650 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports