Expose refspec and depth to runner
What does this MR do?
This MR exposes refspecs
and depth
(for git-fetch) to runners according to this specification.
GitLab-Runner uses the exposed spec and depth in order to checkout source code.
We're going to use merge request's refs (e.g. refs/merge-requests/:iid/head
) in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25504.
POST jobs/request
Sample response on When the job is not associated with a merge request
{
"id":6594,
"token":"FNWRozxyDZ4Q1HHWyW-1",
"allow_git_fetch":true,
"job_info":{
"name":"deploy",
"stage":"test",
"project_id":89,
"project_name":"prospective-merge-pipelines"
},
"git_info":{
"repo_url":"http://gitlab-ci-token:FNWRozxyDZ4Q1HHWyW-1@localhost:8181/root/prospective-merge-pipelines.git",
"sha":"abb6076c965eec51b92667388be8e7ef559f9ca3",
"before_sha":"0000000000000000000000000000000000000000",
"ref":"patch-7",
"ref_type":"branch",
"refspecs":[
"+refs/heads/*:refs/remotes/origin/*",
"+refs/tags/*:refs/tags/*"
],
"depth":0
},
...
}
What are the relevant issue numbers?
Related: https://gitlab.com/gitlab-org/gitlab-ee/issues/7380
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - [-] Documentation created/updated via this MR
- [-] Documentation reviewed by technical writer or follow-up review issue created
-
Tests added for this feature/bug - [-] Tested in all supported browsers
-
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides - [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
-
Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %11.9
added Deliverable + 1 deleted label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Oswaldo Ferreira ( @oswaldo
)Douglas Barbosa Alexandre ( @dbalexandre
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Shinya Maeda
- Resolved by Shinya Maeda
mentioned in merge request !25237 (closed)
- Resolved by Shinya Maeda
- Resolved by Shinya Maeda
@ayufan This is a counter part of gitlab-runner!1092 (closed). Would you mind to perform an early review?
assigned to @ayufan
added 60 commits
-
ece5071b...d9328cb3 - 57 commits from branch
master
- 3dc4fd01 - Expose merge ref to runner
- cf669a16 - Support backward compatibility
- 82d69c59 - Use ref path
Toggle commit list-
ece5071b...d9328cb3 - 57 commits from branch
- Resolved by Shinya Maeda
- Resolved by Shinya Maeda
mentioned in issue gitlab-runner#3983 (closed)
- Resolved by Shinya Maeda
- Resolved by Shinya Maeda
- Resolved by Shinya Maeda
I'm going to decouple merge ref related changes to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25344