Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab Community Edition
GitLab Community Edition
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 14,052
    • Issues 14,052
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 800
    • Merge Requests 800
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab Community EditionGitLab Community Edition
  • Merge Requests
  • !25192

Merged
Opened Feb 13, 2019 by Zeger-Jan van de Weg@zj1 of 2 tasks completed1/2 tasks
  • Report abuse
Report abuse

Add a soft SLA for reviewers and maintainers

What does this MR do?

Set expectations for both reviewers and contributors on when changes are reviewed.

The wording is rather soft I think, by design. From personal experience I know I can review anything assigned to me within a working day. But its hard to judge what the load is on others and I think this is a valuable iteration as is too.

Does this MR meet the acceptance criteria?

  • [-] Changelog entry added, if necessary
  • Documentation created/updated via this MR
  • Documentation reviewed by technical writer or follow-up review issue created
  • [-] Tests added for this feature/bug
  • [-] Tested in all supported browsers
  • [-] Conforms to the code review guidelines
  • [-] Conforms to the merge request performance guidelines
  • [-] Conforms to the style guides
  • [-] Conforms to the database guides
  • [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
  • [-] Security reports checked/validated by reviewer
  • Discussion 12
  • Commits 2
  • Pipelines 3
  • Changes 1
Nick Thomas
Assignee
Nick Thomas @nick.thomas
Assign to
11.9
Milestone
11.9
Assign milestone
Time tracking
3
Labels
Architecture decision Documentation development guidelines
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-ce!25192

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.