Skip to content
Snippets Groups Projects

Fix `import_github_repo_spec.rb`

Merged Sanad Liaquat requested to merge qa-fix-import-github-repo-spec-2 into master
All threads resolved!

What does this MR do?

Fixes the QA tests import_github_repo_spec.rb

EE Port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9716

What are the relevant issue numbers?

Closes #55700 (closed)

Does this MR meet the acceptance criteria?

Edited by Sanad Liaquat

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sanad Liaquat added 1 commit

    added 1 commit

    • 80067acb - Apply suggestion to qa/qa/support/retrier.rb

    Compare with previous version

  • Sanad Liaquat added 1 commit

    added 1 commit

    • 8d7f7d36 - Update and enable github import test

    Compare with previous version

  • Sanad Liaquat resolved all discussions

    resolved all discussions

  • assigned to @sliaquat

  • Sanad Liaquat added 1 commit

    added 1 commit

    • 66fc5e73 - Add logging for NoteImporter and IssueImporter

    Compare with previous version

  • Sanad Liaquat added 1 commit

    added 1 commit

    • 7696c0a0 - Waiting form comment and some refactoring

    Compare with previous version

  • Sanad Liaquat added 1 commit

    added 1 commit

    • d32c3324 - Remove trailing white spaces

    Compare with previous version

  • Sanad Liaquat mentioned in merge request !24606 (merged)

    mentioned in merge request !24606 (merged)

  • Author Maintainer

    There seem to be a transient issue with loading comments on the issue page after GitHub import:

    import_github_repo_spec.rb_2019-02-15-12-39-35.409

    I added some logging in this commit. The application.log (available in the artefacts attached below) from this job shows:

    February 15, 2019 12:36: >>>>>>>>>>>>>>>>>>>>>>>>>>>> NoteImporter attributes: {:noteable_type=>"Issue", :noteable_id=>6, :project_id=>26, :author_id=>1, :note=>"*Created by: rymai*\n\nThis is a comment from @rymai.", :system=>false, :created_at=>2018-06-20 08:32:49 UTC, :updated_at=>2018-06-20 08:32:49 UTC}

    This suggests that the comments were imported correctly. In the tests, we wait for the comments to show up for 60 seconds and also retry asserting up to 3 times by re-navigating to the issue page. So this doesn't seem to be an issue with the tests.

    I ran the tests locally 50 times but couldn't reproduce (yet).

    artifacts__15_.zip

    Edited by Sanad Liaquat
  • Sanad Liaquat mentioned in merge request !25383 (merged)

    mentioned in merge request !25383 (merged)

  • Sanad Liaquat added 199 commits

    added 199 commits

    Compare with previous version

  • Sanad Liaquat added 67 commits

    added 67 commits

    Compare with previous version

  • Sanad Liaquat added 281 commits

    added 281 commits

    Compare with previous version

  • Sanad Liaquat added 1 commit

    added 1 commit

    • 00bb9d36 - Quarantining the test because of a bug

    Compare with previous version

  • Author Maintainer

    I have placed this test in quarantine because of https://gitlab.com/gitlab-org/gitlab-ce/issues/58158

  • Sanad Liaquat added 1 commit

    added 1 commit

    Compare with previous version

  • mentioned in issue #58158 (moved)

  • Sanad Liaquat changed the description

    changed the description

  • Author Maintainer

    @at.ramya This is ready for another round of review. Could you please take a look at this and the EE port MR? Thanks.

  • assigned to @at.ramya

  • Ramya Authappan resolved all discussions

    resolved all discussions

  • Looks good to me! :rocket: Thanks for taking this on!

  • Ramya Authappan approved this merge request

    approved this merge request

  • Ramya Authappan mentioned in commit da8fce1f

    mentioned in commit da8fce1f

  • Please register or sign in to reply
    Loading