Fix `import_github_repo_spec.rb`
What does this MR do?
Fixes the QA tests import_github_repo_spec.rb
EE Port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9716
What are the relevant issue numbers?
Closes #55700 (closed)
Does this MR meet the acceptance criteria?
- [-] Changelog entry added, if necessary
- [-] Documentation created/updated via this MR
- [-] Documentation reviewed by technical writer or follow-up review issue created
- [-] Tests added for this feature/bug
- [-] Tested in all supported browsers
-
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides - [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
- [-] Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %11.9
added Manage [DEPRECATED] QA Quality labels
- Resolved by Sanad Liaquat
Please add one of the following throughput labels: ~"bug", ~"feature", security, Community contribution, ~"backstage"
mentioned in merge request !24018 (closed)
added typebug label
mentioned in issue #57160 (closed)
mentioned in issue #57370 (closed)
added 72 commits
-
87299e9a...032e800b - 71 commits from branch
master
- 87df0af9 - Update and enable github import test
-
87299e9a...032e800b - 71 commits from branch
added 1 commit
- 31701527 - Add QA::Support::Retrier.retry_on_exception and use for verify_issues_import
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Brandon Labuschagne ( @blabuschagne
)Tim Zallmann ( @timzallmann
)QA Ramya Authappan ( @at.ramya
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 62 commits
-
31701527...4b2ba1a7 - 60 commits from branch
master
- 0bba5d19 - Update and enable github import test
- 11b21c46 - Add QA::Support::Retrier.retry_on_exception and use for verify_issues_import
-
31701527...4b2ba1a7 - 60 commits from branch
@at.ramya Could you review please? Thanks.
assigned to @at.ramya
marked the checklist item Conforms to the code review guidelines as completed
marked the checklist item Conforms to the style guides as completed
marked the checklist item Conforms to the database guides as completed
marked the checklist item Conforms to the merge request performance guidelines as completed
- Resolved by Sanad Liaquat
- Resolved by Sanad Liaquat
added 1 commit
- 80067acb - Apply suggestion to qa/qa/support/retrier.rb
assigned to @sliaquat
The
import_github_repo_spec.rb
is flaky and needs more investigation.Failing Jobs:
- https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/161729189
- https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/160850215
- https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/160016775
Passing Jobs:
Edited by Sanad Liaquat- Resolved by Ramya Authappan
added 1 commit
- 66fc5e73 - Add logging for NoteImporter and IssueImporter
mentioned in merge request !24606 (merged)
There seem to be a transient issue with loading comments on the issue page after GitHub import:
I added some logging in this commit. The application.log (available in the artefacts attached below) from this job shows:
February 15, 2019 12:36: >>>>>>>>>>>>>>>>>>>>>>>>>>>> NoteImporter attributes: {:noteable_type=>"Issue", :noteable_id=>6, :project_id=>26, :author_id=>1, :note=>"*Created by: rymai*\n\nThis is a comment from @rymai.", :system=>false, :created_at=>2018-06-20 08:32:49 UTC, :updated_at=>2018-06-20 08:32:49 UTC}
This suggests that the comments were imported correctly. In the tests, we wait for the comments to show up for 60 seconds and also retry asserting up to 3 times by re-navigating to the issue page. So this doesn't seem to be an issue with the tests.
I ran the tests locally 50 times but couldn't reproduce (yet).
Edited by Sanad Liaquatmentioned in merge request !25383 (merged)
added 199 commits
-
d32c3324...50306121 - 195 commits from branch
master
- 904a1e31 - Update and enable github import test
- 20fd8e93 - Add logging for NoteImporter and IssueImporter
- 5ee7f8f3 - Waiting form comment and some refactoring
- bf5705c7 - Remove trailing white spaces
Toggle commit list-
d32c3324...50306121 - 195 commits from branch
mentioned in issue gl-retrospectives/manage#13 (closed)
added 67 commits
-
bf5705c7...8a4cbca2 - 63 commits from branch
master
- 1acd381d - Update and enable github import test
- d9fbd958 - Add logging for NoteImporter and IssueImporter
- 4698d43c - Waiting form comment and some refactoring
- 0b59acbd - Remove trailing white spaces
Toggle commit list-
bf5705c7...8a4cbca2 - 63 commits from branch
added 281 commits
-
0b59acbd...20d84d80 - 277 commits from branch
master
- d46f93cc - Update and enable github import test
- 4e639b85 - Add logging for NoteImporter and IssueImporter
- 0bd7a65b - Waiting form comment and some refactoring
- e8d23f62 - Remove trailing white spaces
Toggle commit list-
0b59acbd...20d84d80 - 277 commits from branch
I have placed this test in quarantine because of https://gitlab.com/gitlab-org/gitlab-ce/issues/58158
mentioned in issue #58158 (moved)
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab-ce/pipelines/49096796 triggered https://gitlab.com/gitlab-org/omnibus-gitlab/pipelines/49137997 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/omnibus-gitlab/pipelines/49137997 triggered https://gitlab.com/gitlab-org/gitlab-qa/pipelines/49145423 downstream.The
gitlab-qa
downstream pipeline passed.
@at.ramya This is ready for another round of review. Could you please take a look at this and the EE port MR? Thanks.
assigned to @at.ramya
mentioned in commit da8fce1f