Skip to content
Snippets Groups Projects

Fix 500 errors with legacy appearance logos

Merged Stan Hu requested to merge sh-fix-issue-9357 into master
All threads resolved!

Prior to GitLab 9.0, attachments were not tracked the uploads table, so it was possible that the appearance logos were just stored in the database as a string and mounted via CarrierWave.

https://gitlab.com/gitlab-org/gitlab-ce/issues/29240 implemented in GitLab 10.3 was supposed to cover populating the uploads table for all attachments, including all the logos from appearances. However, it's possible that didn't work for logos or the uploads entry was orphaned.

GitLab instances that had a customized logo with no associated uploads entry would see Error 500s. The only way to fix this is to delete the logo column from the appearances table and re-upload the attachment.

This change makes things more robust by falling back to the original behavior if the upload is not available.

This is a CE backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9277.

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9357

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks, @stanhu! Just one note.

  • assigned to @stanhu

  • Stan Hu added 1 commit

    added 1 commit

    • 19f9d998 - Fix 500 errors with legacy appearance logos

    Compare with previous version

  • assigned to @dbalexandre

  • Douglas Barbosa Alexandre approved this merge request

    approved this merge request

  • Douglas Barbosa Alexandre resolved all discussions

    resolved all discussions

  • mentioned in commit 8d90f817

  • Stan Hu mentioned in issue #57235 (closed)

    mentioned in issue #57235 (closed)

  • Automatically picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24941, will merge into 11-7-stable ready for 11.7.5.

  • mentioned in commit 5b561b50

  • GitLab Release Tools Bot removed 1 deleted label

    removed 1 deleted label

  • mentioned in merge request !24941 (merged)

  • Please register or sign in to reply
    Loading