Skip to content
Snippets Groups Projects

Add only/except to review-build-cng job

Closed Achilleas Pipinellis requested to merge add-only-except-to-review-build-cng into master
2 unresolved threads

What does this MR do?

This change makes sure that the previous only/except values are ported to the new split job that was introduced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24538.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
960 960 - source ./review-apps.sh
961 961 - wait_for_job_to_be_done "gitlab:assets:compile"
962 962 - BUILD_TRIGGER_TOKEN=$REVIEW_APPS_BUILD_TRIGGER_TOKEN ./$SCRIPT_NAME cng
963 only:
964 refs:
965 - branches@gitlab-org/gitlab-ce
966 - branches@gitlab-org/gitlab-ee
967 kubernetes: active
968 except:
  • 960 960 - source ./review-apps.sh
    961 961 - wait_for_job_to_be_done "gitlab:assets:compile"
    962 962 - BUILD_TRIGGER_TOKEN=$REVIEW_APPS_BUILD_TRIGGER_TOKEN ./$SCRIPT_NAME cng
    963 only:
  • @axil Thanks, LGTM but I left two notes to factorize the config a bit.

  • assigned to @axil

  • Lin Jen-Shin mentioned in merge request !24579 (merged)

    mentioned in merge request !24579 (merged)

  • Let's close this in favor of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24579 (soon to be merged).

  • Please register or sign in to reply
    Loading