Skip to content

Skip CSRF check on SAML failure endpoint

James Edwards-Jones requested to merge jej/avoid-csrf-check-on-saml-failure into master

What does this MR do?

Whitelists :failure endpoint on OmniauthCallbacksController from CSRF checks as this is called when we wish to display an error message or count failed login attempts.

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56574

Might also help with https://gitlab.com/gitlab-org/gitlab-ce/issues/48961 and https://gitlab.com/gitlab-org/gitlab-ce/issues/44913

Does this MR meet the acceptance criteria?

Edited by James Edwards-Jones

Merge request reports