You need to sign in or sign up before continuing.
Adjust emoji and cancel buttons height in user status modal when emoji is changed
requested to merge dhirajbodicherla/gitlab-ce:55884-adjust-emoji-and-cancel-buttons-height-in-user-status-modal-when-emoji-is-changed into master
What does this MR do?
In set user status model, if emoji is changed or text is changed the emoji and cancel buttons become taller than the input. In this MR setting the height of input grp to 34px and adjusted emoji button width.
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55884
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer
Screenshots
Before:
After
Note
Noticed that the emoji placeholder and emoji sizes are different which makes the emoji button grow and shrink when it changes from placeholder to an emoji. Wasn't sure if I should change that as well so. If it was changed it would look like the below gif.
Edited by Dhiraj Bodicherla