Skip to content

[CE] Speed up login page usage

Mark Lapierre requested to merge qa-speed-up-login-page into master

What does this MR do?

When the login page object is used, the first thing it does is check if the login page is visible, then it checks if we're already logged in.

This caused tests to wait 10 seconds for the check for the login page to fail every time the class was used when the test was already logged in. E.g., whenever the test created a personal access token to use for API access.

This MR reverses the order, checking if we're already logged in first, with a wait of 0. This will pass quickly if we're already logged in - in those cases we're not waiting to be able to log in - we expect to be logged in already. It will also fail quickly if we're not logged in, e.g., when a test logs in for the first time.

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8963

Does this MR meet the acceptance criteria?

Edited by Mark Lapierre

Merge request reports