Skip to content

Considerably improve the loading time on merge request's discussion page

What does this MR do?

  1. Caches and uses highlighted diff lines on merge request discussions
  2. Improves the main diff line lookup for each discussion

Profilling results (locally)

Before

Screen_Shot_2018-12-16_at_18.57.04

Consistent response time (55 diff discussions, 10 resolved):

Completed 200 OK in 7461ms (Views: 166.8ms | ActiveRecord: 26.6ms)

After

Screen_Shot_2018-12-16_at_18.57.19

Consistent response time (55 diff discussions, 10 resolved):

Completed 200 OK in 4398ms (Views: 168.0ms | ActiveRecord: 26.5ms)

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52950

Does this MR meet the acceptance criteria?

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading