Avoid loading Wiki Pages content when listed
This MR adds the method list_pages
in ProjectWiki
. This method
allows listing the wiki pages but without loading their content. This
way we can avoid doing it in places we don't need it.
What are the relevant issue numbers?
Closes #53523 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
Merge request reports
Activity
1 Warning 51b4d579: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Felipe Artur ( @felipe_artur
)Stan Hu ( @stanhu
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- d3474d30 - Added load_content option to avoid loading all wiki pages content
marked the checklist item Changelog entry added, if necessary as completed
marked the checklist item Tests added for this feature/bug as completed
changed milestone to %11.5
changed milestone to %11.6
added 8424 commits
-
3f951939...fd8ba987 - 8421 commits from branch
master
- eab3a773 - Added load_content option to avoid loading all wiki pages content
- 2fbc7f03 - Added ProjectWiki#list_pages operation
- 8df9eebb - Adapt wiki's list_pages to new RPC interface
Toggle commit list-
3f951939...fd8ba987 - 8421 commits from branch
added 242 commits
-
8df9eebb...79bf4bda - 239 commits from branch
master
- d8675534 - Added load_content option to avoid loading all wiki pages content
- 1a742f3b - Added ProjectWiki#list_pages operation
- b0fa0df2 - Adapt wiki's list_pages to new RPC interface
Toggle commit list-
8df9eebb...79bf4bda - 239 commits from branch
added 1 commit
- 382b0f5f - Adapt wiki's list_pages to new RPC interface
added 1 commit
- 53eb1997 - Added list_pages method to avoid loading all wiki pages content
assigned to @igor.drozdov
changed milestone to %11.11
added 23 commits
-
53eb1997...474f8dab - 22 commits from branch
master
- c659fba9 - Added list_pages method to avoid loading all wiki pages content
-
53eb1997...474f8dab - 22 commits from branch
assigned to @felipe_artur
@felipe_artur could you please review this MR?
added 1 commit
- 39ca8ce8 - Added list_pages method to avoid loading all wiki pages content
- Resolved by Igor Drozdov
@igor.drozdov Done. I left one question and small suggestions. It looks good to me.
cc @fjsanpedro
assigned to @igor.drozdov
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
added 1 commit
- bedc1dd4 - Added list_pages method to avoid loading all wiki pages content
assigned to @felipe_artur
added 77 commits
-
bedc1dd4...d697c1d8 - 76 commits from branch
master
- dde5888d - Added list_pages method to avoid loading all wiki pages content
-
bedc1dd4...d697c1d8 - 76 commits from branch
added 1 commit
- 4b47f477 - Added list_pages method to avoid loading all wiki pages content
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
@igor.drozdov I left some small comments too, but looks good. BTW, I think we can replace
load_page
withlist_pages
in almost all the specs, but I'm not sure if it is worth it.
assigned to @igor.drozdov
added 1 commit
- 18aaf382 - Added list_pages method to avoid loading all wiki pages content
added 1 commit
- bdbe7e47 - Added list_pages method to avoid loading all wiki pages content
added 35 commits
-
bdbe7e47...8ede9d18 - 34 commits from branch
master
- 9ffaf6fb - Added list_pages method to avoid loading all wiki pages content
-
bdbe7e47...8ede9d18 - 34 commits from branch
added 1 commit
- 6300d539 - Added list_pages method to avoid loading all wiki pages content
assigned to @felipe_artur
- Resolved by Igor Drozdov
Looks good to me @igor.drozdov thanks!
I just left one small suggestion, not required.
assigned to @igor.drozdov
added 1 commit
- 3ef7a3db - Added list_pages method to avoid loading all wiki pages content
added 1 commit
- d73a8314 - Added list_pages method to avoid loading all wiki pages content
added 250 commits
-
d73a8314...9ec37d3d - 249 commits from branch
master
- 3a17e372 - Added list_pages method to avoid loading all wiki pages content
-
d73a8314...9ec37d3d - 249 commits from branch
@stanhu could you please review this MR?
assigned to @stanhu
- Resolved by Igor Drozdov
added 1 commit
- 1c9fd12f - Apply suggestion to app/models/project_wiki.rb
added 1 commit
- 62a200b4 - Added list_pages method to avoid loading all wiki pages content
added 193 commits
-
62a200b4...04519162 - 192 commits from branch
master
- 51b4d579 - Added list_pages method to avoid loading all wiki pages content
-
62a200b4...04519162 - 192 commits from branch
enabled an automatic merge when the pipeline for 51b4d579 succeeds
@igor.drozdov Looks good to me, thanks!
Merging because failure is unrelated and on master: https://gitlab.com/gitlab-org/gitlab-ce/issues/60953
mentioned in commit f3b3d8b1
mentioned in issue gitlab-org/release/tasks#778 (closed)