Skip to content

Add Discord integration

blackst0ne requested to merge blackst0ne-add-discord-service into master

What does this MR do?

Adds a news service - integration with Discord

What are the relevant issue numbers?

Closes #21635 (closed)

Why using fork?

This MR brings the usage of discordrb-webhooks-blackst0ne - a fork of mine. Why do we need to use the fork instead of the upstream version of the gem?

The reason is in dependency conflicts.

The upstream discordrb gem requires 'rest-client >= 2.1.0.rc1' At the same time kubeclient we already use requires 'rest-client ~> 2.0' which raises dependency conflicts.

I have forked discordrb and relaxed the dependency of rest-client. Now it requires 'rest-client ~> 2.0' - the same version as kubeclient expects.

The dependency of rest-client >= 2.1.0.rc1 was added to fix some bugs for Ruby 2.5 on Windows OSes. So it seems we can just relax dependencies and use the gem.

This fork should be replaced by the upstream version when both discordrb and kubeclient start requiring the same version of rest-client.

Does this MR meet the acceptance criteria?

Edited by blackst0ne

Merge request reports