Add feature flag for workhorse content type calculation
What does this MR do?
Added a new feature flag to manage the new changes made in Workhorse for calculating the content-type
and content-disposition
.
This MR introduces a new header as a signaling mechanism for Workhorse:
-
Gitlab-Workhorse-Detect-Content-Type
. This flag will be set when the feature is enabled and only if the response has the headersX-Sendfile
or specifically in any place we want Workhorse to detect the content type. This header is the same one Workhorse uses to determine if it has to act in the response. Only if Workhorse seesGitlab-Workhorse-Detect-Content-Type
the new behavior will run. - The feature flag that handles this new behavior is
workhorse_set_content_type
The MR with the changes in Workhorse is gitlab-workhorse!335 (merged)
What are the relevant issue numbers?
Refs: https://gitlab.com/gitlab-org/gitlab-ce/issues/36103
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
Edited by Nick Thomas