Delete job_spec.js
What does this MR do?
Deletes job_spec.js
because https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22116 deleted app/assets/javascripts/job.js
, so the corresponding test file is probably no longer relevant.
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/50904
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
Merge request reports
Activity
@filipa Can you please review / merge?
assigned to @filipa
mentioned in merge request !22116 (merged)
enabled an automatic merge when the pipeline for 38a4a8bf succeeds
1 Error 38a4a8bf: The commit subject must contain at least three words 1 Warning CHANGELOG missing. You can create one with:
bin/changelog -m 22664 "Delete job_spec.js"
If your merge request doesn’t warrant a CHANGELOG entry,
consider adding any of the ~backstage, ~Documentation, QA, test labels.
See the documentation.Commit message standards
One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Generated by
Dangermentioned in commit 6e743299
mentioned in issue gitlab-org/release/tasks#515 (closed)