Stop Repository#fetch_remote from using Gitlab::Shell (!22635) · Merge requests · GitLab.org / GitLab FOSS · GitLab

The 17.0 major release is coming on May 16, 2024! This version brings many exciting improvements to GitLab, but also removes some deprecated features. We are introducing three breaking change windows during which we expect breaking changes to be deployed to GitLab.com. You can read more about it on our blogpost . The third breaking change window begins 2024-05-06 09:00 UTC and ends 2024-05-08 22:00 UTC.

The source project of this merge request has been removed.

Nick Thomas requested to merge (removed):unindirect-fetch-remote into master Oct 26, 2018

What does this MR do?

Noticed while working on https://gitlab.com/gitlab-org/gitlab-ce/issues/49565

Repository#fetch_remote indirects through gitlab-shell, but doesn't need to, since it's now an unconditionally Gitaly operation.

Removing the indirection and cleaning up the code a little saves a whole line of code 😱 and makes the code a little easier to follow.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Changelog entry added, if necessary
Documentation created/updated
Tests added for this feature/bug
Conforms to the code review guidelines
Conforms to the merge request performance guidelines
Conforms to the style guides
Conforms to the database guides
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.

Edited Nov 05, 2018 by Nick Thomas