Add transparent background to markdown header tabs
What does this MR do?
Markdown header tabs were changed to buttons in !21988 (merged). This caused a minor style inconsistency on some user agents.
Before | After |
---|---|
![]() |
![]() |
What are the relevant issue numbers?
Fix #53105 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has ~"Requires e2 tests" label. See the Test Planning Process.
Merge request reports
Activity
mentioned in issue #53105 (closed)
added 1 commit
- 818e6c8a - Add transparent background to markdown header tabs
marked the checklist item Changelog entry added, if necessary as completed
@andr3 this will add a transparent background to these tab buttons. I couldn't locate any other buttons nested inside
nav-links
that were affected by this. Could you review or forward this to someone on the FE team?Edited by George Tsiolisadded 11 commits
-
818e6c8a...0baa0c4b - 10 commits from branch
gitlab-org:master
- 64aab228 - Add transparent background to markdown header tabs
-
818e6c8a...0baa0c4b - 10 commits from branch
@gtsiolis wow, thanks for the quick fix!
Sorry for maybe throwing you off in the wrong direction, but I see we'd have to add a variable for this
rgba()
.. I suggested because I saw it somewhere being used for this, but as it turns out, inspecting the previous solution shows the previously used<a>
had abackground-color: transparent;
so I'd prefer that, being a targeted fix and all.Would you mind changing that to transparent? After that I'll assign to a maintainer. :) THanks again!
No problem @andr3! Yes,
transparent
is much better since this also avoids introducing a new SCSS variable. It seems to be working just fine, too!added 1 commit
- f9d6ee82 - Add transparent background to markdown header tabs
added Create [DEPRECATED] UI polish typebug labels
assigned to @iamphill
enabled an automatic merge when the pipeline for f9d6ee82 succeeds
Thanks @gtsiolis
mentioned in commit 83b4cab7
mentioned in merge request !22449 (merged)
mentioned in issue gitlab-org/release/tasks#515 (closed)
added Community contribution label
changed milestone to %11.5
added devopscreate label