Revert "Merge branch 'refactor-cluster-create-service-spec' into 'master'"
What does this MR do?
Reverts https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22407. As found in the CE-to-EE merge, it is used in more than one place but only in EE. :(
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
- [-] Changelog entry added, if necessary
- [-] Documentation created/updated
-
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines - [-] Conforms to the style guides
- [-] Conforms to the database guides
Merge request reports
Activity
added backstage [DEPRECATED] + 1 deleted label
changed milestone to %11.5
assigned to @tkuah
2 Errors 305ab040: The commit subject may not be longer than 72 characters 305ab040: Use full URLs instead of short references ( gitlab-org/gitlab-ce#123
or!123
), as short references are displayed as plain text outside of GitLab1 Warning This merge request adds files that do not enforce frozen string literal. See https://gitlab.com/gitlab-org/gitlab-ce/issues/47424 for more information. Enable Frozen String Literal
The following files should have
# frozen_string_literal: true
on the first line:spec/support/services/clusters/create_service_shared.rb
Commit message standards
One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Generated by
Dangerassigned to @rspeicher
mentioned in commit 4cf1845e
@tkuah LGTM, thanks!
mentioned in issue gitlab-org/release/tasks#515 (closed)
added devopsconfigure [DEPRECATED] label
added groupconfigure [DEPRECATED] label
added groupenvironments label and removed groupconfigure [DEPRECATED] label