Remove base64 encoding from files that contain plain text
What does this MR do?
This merge request fixes the issue where files containing plain text were base64 encoded after being uploaded from the WebIDE.
Any file without the text/*
mime type is base64 encoded and as a result, the contents of the file in the repo was base64 encoded even if it contains plain text.
This MR prevents this issue by removing the base64 encoding if the file contains plain text.
What are the relevant issue numbers?
Closes: #48746 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines
Merge request reports
Activity
mentioned in merge request !22252 (closed)
@psimyn could you please have a look at this one?
assigned to @psimyn
@psimyn also, do you have any idea what could be causing the pipeline to fail?
I got this error in the
ee_compat_check
step:ERROR: Job failed (system failure): Error: No such container: e9db63f95c82efedbcaef1c59f512d6cb35964cc4e684c230621433475611d6f (executor_docker.go:964:0s)
Hi @jerasmus,
Please add labels to your merge request, this helps triage community merge requests.
Thanks for your help!
You are welcome to help improve this comment.
added auto updated label
- Resolved by Simon Knox
- Resolved by Simon Knox
- Resolved by Simon Knox
- Resolved by Simon Knox
@jerasmus missing Docker image just happens sometimes. I gave it a retry and was fine.
I had a couple of questions/suggestions. Encoding is crazy
assigned to @jerasmus
2 Warnings This merge request does not refer to an existing milestone. This merge request includes more than 10 commits. Please rebase these commits into a smaller number of commits. Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 153fe5df - Updated the `isText` method to test for file types
@psimyn I've addressed your comments, could you please have another look.
assigned to @psimyn
assigned to @iamphill
mentioned in commit 1438e322
Nice! Thanks @jerasmus
mentioned in issue gitlab-org/release/tasks#515 (closed)
mentioned in merge request gitlab-com/www-gitlab-com!16282 (closed)
changed milestone to %11.5
mentioned in issue gitlab#26113 (closed)