Update environments empty state
What does this MR do?
Update environments empty state, according to UX guidelines for paragraph alignment and more in #40468 (closed).
Before | After |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides
Merge request reports
Activity
@dimitrieh could you review UX here or forward this to someone else on the UX team?
marked the checklist item Changelog entry added, if necessary as completed
added Community contribution label
@gtsiolis I've reviewed frontend changes here, they look fine to me.
Just be sure to run
bundle exec rake gettext:regenerate
and commit updatedgitlab.pot
file.Once UX is reviewed, it can go to maintainer.
Edited by Kushal Pandyaadded 13 commits
-
70ebd44e...a5ecb5bb - 12 commits from branch
gitlab-org:master
- 0eb7e029 - Update environments empty state
-
70ebd44e...a5ecb5bb - 12 commits from branch
Many thanks @kushalpandya, I've just added the missing translated strings! These were skipped by accident during the merge request split (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21975#note_107586130).
- Resolved by George Tsiolis
Pipeline failure not related.
Edited by George Tsiolis
added 42 commits
-
0eb7e029...0d3cc866 - 41 commits from branch
gitlab-org:master
- 17e2208c - Update environments empty state
-
0eb7e029...0d3cc866 - 41 commits from branch
mentioned in merge request !21975 (closed)
assigned to @filipa
- Resolved by George Tsiolis
@gtsiolis @dimitrieh @kushalpandya where is the issue with the plan for this MR?
assigned to @gtsiolis
added 101 commits
-
17e2208c...d87e88a6 - 100 commits from branch
gitlab-org:master
- 3a929042 - Update environments empty state
-
17e2208c...d87e88a6 - 100 commits from branch
@filipa this is an ongoing effort (!21974 (merged), !21976 (merged), !22218 (merged), !18348 (merged), https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7358) to fix empty state inconsistencies (see https://gitlab.com/gitlab-org/design.gitlab.com/issues/115#note_105509332). I don't think there's a roadmap issue for this. I would consider making one after having fully documented all possible empty state variants in https://gitlab.com/gitlab-org/design.gitlab.com/issues/115. /cc @gitlab-com/gitlab-ux
- Resolved by George Tsiolis
- Resolved by George Tsiolis
- Resolved by George Tsiolis
- Resolved by George Tsiolis
@filipa I've restored the specs. Sorry for missing these, but I think I got a bit overwhelmed with the changes in !21975 (closed). This should be ok now. Tests are passing locally.
Edited by George Tsiolisadded 13 commits
-
3a929042...9642a472 - 12 commits from branch
gitlab-org:master
- de8cb211 - Update environments empty state
-
3a929042...9642a472 - 12 commits from branch
mentioned in merge request !18348 (merged)
Thank you @gtsiolis! No apologies needed!
Code LGTM, I'll set to MWPS
mentioned in commit d32ac958
@filipa muito obrigado!
added Deliverable Plan [DEPRECATED] UI polish frontend workflowin review + 1 deleted label
changed milestone to %10.4
@gtsiolis Thanks!
changed milestone to %11.5
@filipa Assigning to you so that the QA item mentions you when the time comes
assigned to @filipa
mentioned in issue gitlab-org/release/tasks#515 (closed)
added devopsplan label