Skip to content
Snippets Groups Projects

Update environments empty state

All threads resolved!

What does this MR do?

Update environments empty state, according to UX guidelines for paragraph alignment and more in #40468 (closed).

Before After
env-before env-after

Does this MR meet the acceptance criteria?

Edited by George Tsiolis

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @gtsiolis @dimitrieh @kushalpandya where is the issue with the plan for this MR?

  • George Tsiolis added 101 commits

    added 101 commits

    Compare with previous version

  • George Tsiolis changed the description

    changed the description

  • George Tsiolis resolved all discussions

    resolved all discussions

  • Author Developer

    @filipa this is an ongoing effort (!21974 (merged), !21976 (merged), !22218 (merged), !18348 (merged), https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7358) to fix empty state inconsistencies (see https://gitlab.com/gitlab-org/design.gitlab.com/issues/115#note_105509332). I don't think there's a roadmap issue for this. I would consider making one after having fully documented all possible empty state variants in https://gitlab.com/gitlab-org/design.gitlab.com/issues/115. /cc @gitlab-com/gitlab-ux

  • George Tsiolis resolved all discussions

    resolved all discussions

  • Author Developer

    @filipa I've restored the specs. Sorry for missing these, but I think I got a bit overwhelmed with the changes in !21975 (closed). This should be ok now. Tests are passing locally. :sweat_smile:

    Edited by George Tsiolis
  • George Tsiolis added 13 commits

    added 13 commits

    Compare with previous version

  • George Tsiolis mentioned in merge request !18348 (merged)

    mentioned in merge request !18348 (merged)

  • George Tsiolis added 1 commit

    added 1 commit

    • ea75b727 - Update environments empty state

    Compare with previous version

  • Thank you @gtsiolis! No apologies needed!

    Code LGTM, I'll set to MWPS

  • Filipa Lacerda approved this merge request

    approved this merge request

  • Filipa Lacerda mentioned in commit d32ac958

    mentioned in commit d32ac958

  • Author Developer

    @filipa muito obrigado! :star2:

  • Author Developer

    This is missing milestone. /cc @gitlab-org/issue-triage

  • Mark Fletcher changed milestone to %10.4

    changed milestone to %10.4

  • Mark Fletcher changed milestone to %11.5

    changed milestone to %11.5

  • @filipa Assigning to you so that the QA item mentions you when the time comes

  • assigned to @filipa

  • Please register or sign in to reply
    Loading