Skip to content
Snippets Groups Projects

Allow getting the merge base of multiple revisions

All threads resolved!

What does this MR do?

Since gitaly!869 (merged) Gitaly supports getting the common ancestor for multiple revisions. We can now support this in our API

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52573

Does this MR meet the acceptance criteria?

Edited by Bob Van Landuyt

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Zeger-Jan van de Weg
  • added 1 commit

    • c0960f9a - WIP: Batch load commits for merge base

    Compare with previous version

  • Bob Van Landuyt marked as a Work In Progress from reprazent/gitlab-ce@c0960f9a

    marked as a Work In Progress from reprazent/gitlab-ce@c0960f9a

  • added 1 commit

    • 71d71afb - Allow getting the merge base of multiple revisions

    Compare with previous version

  • Bob Van Landuyt resolved all discussions

    resolved all discussions

  • Bob Van Landuyt unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Author Maintainer

    @zj I removed the need for loading the commits from Repository#merge_base since we can just pass the ref to Gitaly for that. I did add a spec to check if we aren't calling Gitaly more than once.

    WDYT?

  • assigned to @zj

  • Zeger-Jan van de Weg approved this merge request

    approved this merge request

  • Assiging @DouweM as its create, and to show that @reprazent finished his first Go feature ;)

  • merged

  • Douwe Maan mentioned in commit 3c15a20b

    mentioned in commit 3c15a20b

  • Please register or sign in to reply
    Loading