Skip to content
Snippets Groups Projects

Fix erased block not being rendered when job was erased

Merged Filipa Lacerda requested to merge 52570-erased-block into master
All threads resolved!

What does this MR do?

Fix erased block not being rendered when job was erased

What are the relevant issue numbers?

Closes #52570 (closed)

Does this MR meet the acceptance criteria?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1 Error
    :no_entry_sign: b258cbab: The commit subject and body must be separated by a blank line
    2 Warnings
    :warning: 13e59bca: This commit’s subject line could be improved. Commit subjects are ideally no longer than roughly 50 characters, though we allow up to 72 characters in the subject. If possible, try to reduce the length of the subject to roughly 50 characters.
    :warning: This merge request changed frontend files without pretty printing them.

    Commit message standards

    One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.

    Here is an example of a good commit message:

    Reject ruby interpolation in externalized strings
    
    When using ruby interpolation in externalized strings, they can't be
    detected. Which means they will never be presented to be translated.
    
    To mix variables into translations we need to use `sprintf`
    instead.
    
    Instead of:
    
        _("Hello #{subject}")
    
    Use:
    
        _("Hello %{subject}") % { subject: 'world' }

    This is an example of a bad commit message:

    updated README.md

    This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.

    Pretty print Frontend files

    The following files should have been pretty printed with prettier:

    • app/assets/javascripts/jobs/components/job_app.vue

    Please run

    node_modules/.bin/prettier --write \
      'app/assets/javascripts/jobs/components/job_app.vue'

    Also consider auto-formatting on-save.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Filipa Lacerda added 1 commit

    added 1 commit

    • b258cbab - Updates rspec to check for text within the

    Compare with previous version

  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • assigned to @filipa

  • Filipa Lacerda added 1 commit

    added 1 commit

    • b358818d - Remove trailing whitespace jobs_spec.rb

    Compare with previous version

  • Author Contributor

    @mikegreiling can you please review this one? Thanks!

  • Thanks @filipa this LGTM :thumbsup_tone1:

  • Mike Greiling approved this merge request

    approved this merge request

  • merged

  • Mike Greiling mentioned in commit 80a1bb1d

    mentioned in commit 80a1bb1d

  • Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22301, will merge into 11-4-stable ready for 11.4 RC4

  • Cindy Pallares 🦉 removed 1 deleted label

    removed 1 deleted label

  • Mike Greiling mentioned in commit dd411a20

    mentioned in commit dd411a20

  • Please register or sign in to reply
    Loading