Fix erased block not being rendered when job was erased
What does this MR do?
Fix erased block not being rendered when job was erased
What are the relevant issue numbers?
Closes #52570 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides
Merge request reports
Activity
- Resolved by Filipa Lacerda
1 Error b258cbab: The commit subject and body must be separated by a blank line 2 Warnings 13e59bca: This commit’s subject line could be improved. Commit subjects are ideally no longer than roughly 50 characters, though we allow up to 72 characters in the subject. If possible, try to reduce the length of the subject to roughly 50 characters. This merge request changed frontend files without pretty printing them. Commit message standards
One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Pretty print Frontend files
The following files should have been pretty printed with
prettier
:app/assets/javascripts/jobs/components/job_app.vue
Please run
node_modules/.bin/prettier --write \ 'app/assets/javascripts/jobs/components/job_app.vue'
Also consider auto-formatting on-save.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖assigned to @filipa
@mikegreiling can you please review this one? Thanks!
assigned to @mikegreiling
Thanks @filipa this LGTM
mentioned in commit 80a1bb1d
Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22301, will merge into
11-4-stable
ready for11.4 RC4
mentioned in commit dd411a20
mentioned in issue gl-retrospectives/verify#1 (closed)
mentioned in issue gitlab-org/release/tasks#482 (closed)
mentioned in issue gitlab-org/release/tasks#515 (closed)