Adds `.json` to the end of pipelines endpoint
What does this MR do?
The problem is explained here:
Why are we not using the
.json
in the url? But sending theapplication/json
header instead for the json response? This is most likely the reason it gets cached because we usehttps://gitlab.com/gitlab-org/gitlab-ce/pipelines/32543288
nothttps://gitlab.com/gitlab-org/gitlab-ce/pipelines/32543288.json
so when the user clicks the back button the browser sees it's the same url so sends over the Etag and caching takes effect. I think we just append.json
for the request of the pipelines it should solve this problem.
This MR adds .json
to the endpoint. We had this issue in the past, when we first started moving things into Vue and I forgot about it.
What are the relevant issue numbers?
Closes #52472 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides
Merge request reports
Activity
1 Warning This merge request does not refer to an existing milestone. Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Steve Xuereb
added 1 commit
- 0073be9b - Adds `.json` to the end of pipelines endpoint
@timzallmann can you please review this one? Thanks!
assigned to @timzallmann
Thanks @filipa , can we add the
.json
to any check list?mentioned in commit a8513c7d
@timzallmann do you mean documenting it? I tried to think of a proper way to test it but couldn't think of anything
@filipa Yes documenting, I am more and mroe in the understanding we need a MR review checklist.
@timzallmann started an issue here: https://gitlab.com/gitlab-org/gitlab-ce/issues/52579 will add more things there
mentioned in issue #52583 (closed)
mentioned in issue #52584 (closed)
Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22301, will merge into
11-4-stable
ready for11.4 RC4
mentioned in commit 31ae0e5d
mentioned in issue gitlab-org/release/tasks#482 (closed)
mentioned in issue gitlab-org/release/tasks#515 (closed)
changed milestone to %11.5
mentioned in issue #65208 (moved)