Skip to content
Snippets Groups Projects

Adds `.json` to the end of pipelines endpoint

Merged Filipa Lacerda requested to merge 52472-pipeline-endpoint-json into master
All threads resolved!

What does this MR do?

The problem is explained here:

Why are we not using the .json in the url? But sending the application/json header instead for the json response? This is most likely the reason it gets cached because we use https://gitlab.com/gitlab-org/gitlab-ce/pipelines/32543288 not https://gitlab.com/gitlab-org/gitlab-ce/pipelines/32543288.json so when the user clicks the back button the browser sees it's the same url so sends over the Etag and caching takes effect. I think we just append .json for the request of the pipelines it should solve this problem.

This MR adds .json to the endpoint. We had this issue in the past, when we first started moving things into Vue and I forgot about it.

What are the relevant issue numbers?

Closes #52472 (closed)

Does this MR meet the acceptance criteria?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This works well for me locally!

  • Filipa Lacerda added 1 commit

    added 1 commit

    • 0073be9b - Adds `.json` to the end of pipelines endpoint

    Compare with previous version

  • Filipa Lacerda added 1 commit

    added 1 commit

    • 8bc33c78 - Adds MR id to changelog entry

    Compare with previous version

  • Steve Xuereb resolved all discussions

    resolved all discussions

  • Author Contributor

    @timzallmann can you please review this one? Thanks!

  • Thanks @filipa , can we add the .json to any check list?

  • Tim Zallmann approved this merge request

    approved this merge request

  • merged

  • Tim Zallmann mentioned in commit a8513c7d

    mentioned in commit a8513c7d

  • Author Contributor

    @timzallmann do you mean documenting it? I tried to think of a proper way to test it but couldn't think of anything

  • @filipa Yes documenting, I am more and mroe in the understanding we need a MR review checklist.

  • Author Contributor

    @timzallmann started an issue here: https://gitlab.com/gitlab-org/gitlab-ce/issues/52579 will add more things there

  • mentioned in issue #52583 (closed)

  • mentioned in issue #52584 (closed)

  • Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22301, will merge into 11-4-stable ready for 11.4 RC4

  • Cindy Pallares 🦉 removed 1 deleted label

    removed 1 deleted label

  • Tim Zallmann mentioned in commit 31ae0e5d

    mentioned in commit 31ae0e5d

  • Elliot Rushton added 1 deleted label and removed 1 deleted label

    added 1 deleted label and removed 1 deleted label

  • Rémy Coutable changed milestone to %11.5

    changed milestone to %11.5

  • Stan Hu mentioned in issue #65208 (moved)

    mentioned in issue #65208 (moved)

  • Please register or sign in to reply
    Loading