Document the role of the maintainer
Merge request reports
Activity
- Resolved by Douwe Maan
@DouweM LGTM, just one fix.
3 Errors 2a631de5: The commit subject must not end with a period 90056ed2: The commit subject must not end with a period eb0ded1d: The commit subject may not be longer than 72 characters 5 Warnings This merge request does not refer to an existing milestone. CHANGELOG missing. You can create one with:
bin/changelog -m 22232 "Document the role of the maintainer"
If your merge request doesn’t warrant a CHANGELOG entry,
consider adding any of the ~backstage, ~Documentation, QA, test labels.
See the documentation.This merge request is missing the ~Documentation label. 2a631de5: This commit’s subject line could be improved. Commit subjects are ideally no longer than roughly 50 characters, though we allow up to 72 characters in the subject. If possible, try to reduce the length of the subject to roughly 50 characters. 90056ed2: This commit’s subject line could be improved. Commit subjects are ideally no longer than roughly 50 characters, though we allow up to 72 characters in the subject. If possible, try to reduce the length of the subject to roughly 50 characters. 1 Message This merge request adds or changes files that require a review from the docs team. Docs Review
The following files require a review from the Documentation team:
doc/development/code_review.md
To make sure these changes are reviewed, mention
@gl-docsteam
in a separate comment, and explain what needs to be reviewed by the team. Please don't mention the team until your changes are ready for review.Commit message standards
One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.
Here is an example of a good commit message:
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}") % { subject: 'world' }
This is an example of a bad commit message:
updated README.md
This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖Hi @DouweM,
Please add labels to your merge request, this helps triage community merge requests.
Thanks for your help!
You are welcome to help improve this comment.
added auto updated label
added 1 commit
- eb0ded1d - Rewrite guidance on getting your merge request reviewed, approved, and merged
- Resolved by Douwe Maan
- Resolved by Douwe Maan
Please review these changes in response to the discussion in https://gitlab.com/gitlab-org/gitlab-ce/issues/52114!
@ayufan @dbalexandre @dzaporozhets @grzesiek @nick.thomas @rspeicher @rymai @smcgivern @annabeldunstone @ClemMakesApps @fatihacet @filipa @iamphill @mikegreiling @timzallmann
assigned to @smcgivern
- Resolved by Fatih Acet
- Resolved by Douwe Maan
- Resolved by Douwe Maan
- Resolved by Douwe Maan
- Resolved by Douwe Maan
- Resolved by Douwe Maan
- Resolved by Douwe Maan
- Resolved by Douwe Maan
- Resolved by Douwe Maan
assigned to @DouweM
added 1 commit
- 90056ed2 - Clarify responsibilities of MR author and maintainer based on feedback.
assigned to @smcgivern
I've updated the MR based on the feedback, and marked @nick.thomas, @smcgivern, @grzesiek, @rymai and @filipa as required approvers since the most significant feedback on the issue and the MR came from them.
Please have a look!
added 236 commits
-
90056ed2...68eafa50 - 235 commits from branch
master
- a706b373 - Merge branch 'master' into 'dm-document-role-maintainer'
-
90056ed2...68eafa50 - 235 commits from branch
- Resolved by Grzegorz Bizon
- Resolved by Douwe Maan
@DouweM works for me (one minor question aside), thanks! Assigning to the next in the approvals list.
assigned to @rymai
mentioned in issue #52788 (closed)
- Resolved by Grzegorz Bizon
@DouweM I left just two questions!
- Resolved by Douwe Maan
@DouweM LGTM, I only left minor notes, so I'm approving already and passing to you since it seems there are other discussions to be resolved.
assigned to @DouweM
added 1 commit
- 2a631de5 - Strongly recommend involving a domain expert, especially when in doubt.
assigned to @grzesiek
Thanks for your feedback, everyone!
@grzesiek Please have a look at my attempt at addressing your concerns, and please resolve the discussions and approve and merge the MR if you think it's sufficient :)
mentioned in commit 4ef9bb6a