Skip to content
Snippets Groups Projects

Resolve "Show canary / no-canary in the performance bar"

Merged Sean McGivern requested to merge 52421-show-canary-no-canary-in-the-performance-bar into master
All threads resolved!

What does this MR do?

In the performance bar, show a bird emoji, and colour the hostname in yellow, if you're on a canary host.

In production, it will look like this:

image

Does this MR meet the acceptance criteria?

Closes #52421 (closed).

Edited by Sean McGivern

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @smcgivern! LGTM, I just need @MadLittleMods to double check the emoji itself, he has more experience with them

  • @smcgivern Love the :bird: emoji! I don't mind the crazy yellow color to be honest; the high contrast is super readable. Why did you choose that exact hex color though?

  • Author Contributor

    @annabeldunstone I followed my patented two-step process for picking a colour for use in GitLab:

    1. I looked at https://design.gitlab.com/foundations/colors and didn't see a yellow.
    2. I Googled 'canary yellow hex'.

    So, as you can see, I can use all the help I can get!

  • Sean McGivern added 1 commit

    added 1 commit

    • 3cebd1a3 - Show if the host is a canary host in the perf bar

    Compare with previous version

  • Author Contributor

    Thanks @MadLittleMods, updated!

  • Sean McGivern added 1 commit

    added 1 commit

    • bd07d133 - Show if the host is a canary host in the perf bar

    Compare with previous version

  • assigned to @filipa

  • Filipa Lacerda
  • Thanks @smcgivern, just a tiny thing. Sorry I missed it on first review

  • Sean McGivern added 1 commit

    added 1 commit

    • 92c69ff1 - Show if the host is a canary host in the perf bar

    Compare with previous version

  • Author Contributor

    @filipa thanks, updated! If you're happy, please assign to @pedroms as we need UX approval still.

  • Sean McGivern added 1 commit

    added 1 commit

    • 9dc336da - Show if the host is a canary host in the perf bar

    Compare with previous version

  • assigned to @filipa

  • Filipa Lacerda approved this merge request

    approved this merge request

  • assigned to @pedroms

  • Sean McGivern added 1 commit

    added 1 commit

    • 22d6ad75 - Show if the host is a canary host in the perf bar

    Compare with previous version

  • assigned to @pedroms

  • Pedro Moreira da Silva resolved all discussions

    resolved all discussions

  • Pedro Moreira da Silva approved this merge request

    approved this merge request

  • Sean McGivern changed the description

    changed the description

  • merged

  • Author Contributor

    Thanks everyone! :baby_chick:

  • Sean McGivern mentioned in commit 05dd7f97

    mentioned in commit 05dd7f97

  • Please register or sign in to reply
    Loading