Resolve "Show canary / no-canary in the performance bar"
What does this MR do?
In the performance bar, show a bird emoji, and colour the hostname in yellow, if you're on a canary host.
In production, it will look like this:
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Tests added for this feature/bug
Closes #52421 (closed).
Merge request reports
Activity
assigned to @smcgivern
marked the checklist item Changelog entry added, if necessary as completed
added 1 commit
- 95f894f3 - Show if the host is a canary host in the perf bar
- Resolved by Pedro Moreira da Silva
@annabeldunstone @pedroms could one of you do the UX review here, please? I think a less bright yellow might be a good idea
@filipa could you review the FE changes?
assigned to @filipa
- Resolved by Sean McGivern
Thanks @smcgivern! LGTM, I just need @MadLittleMods to double check the emoji itself, he has more experience with them
assigned to @MadLittleMods
assigned to @smcgivern
@smcgivern Love the
emoji! I don't mind the crazy yellow color to be honest; the high contrast is super readable. Why did you choose that exact hex color though?@annabeldunstone I followed my patented two-step process for picking a colour for use in GitLab:
- I looked at https://design.gitlab.com/foundations/colors and didn't see a yellow.
- I Googled 'canary yellow hex'.
So, as you can see, I can use all the help I can get!
added 1 commit
- 3cebd1a3 - Show if the host is a canary host in the perf bar
Thanks @MadLittleMods, updated!
assigned to @MadLittleMods
added 1 commit
- bd07d133 - Show if the host is a canary host in the perf bar
assigned to @filipa
- Resolved by Sean McGivern
Thanks @smcgivern, just a tiny thing. Sorry I missed it on first review
assigned to @smcgivern
added 1 commit
- 92c69ff1 - Show if the host is a canary host in the perf bar
added 1 commit
- 9dc336da - Show if the host is a canary host in the perf bar
assigned to @filipa
Thanks @smcgivern!
assigned to @pedroms
assigned to @smcgivern
added 1 commit
- 22d6ad75 - Show if the host is a canary host in the perf bar
assigned to @pedroms
assigned to @smcgivern
mentioned in commit 05dd7f97
mentioned in issue gitlab-org/release/tasks#515 (closed)
added devopsplan label