Skip to content
Snippets Groups Projects

Removes expensive dead code on main MR page request

Merged Oswaldo Ferreira requested to merge osw-remove-dead-code-on-mr-show into master
All threads resolved!

What does this MR do?

Removes expensive dead code.

Screen_Shot_2018-10-05_at_10.21.55

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51172

Does this MR meet the acceptance criteria?

Edited by Oswaldo Ferreira

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robert Speicher
  • @oswaldo Thanks! :thumbsup: :blue_heart: Just one question to possibly remove more dead code. Although this missed feature freeze, I think an exception request for a performance improvement on a common page like this should be approved pretty easily.

  • assigned to @oswaldo

  • Author Contributor

    I'll submit a exception request! Answered your question, thanks @rspeicher!

  • Robert Speicher approved this merge request

    approved this merge request

  • Robert Speicher resolved all discussions

    resolved all discussions

  • @oswaldo LGTM, thanks! :thumbsup: :green_heart:

  • Robert Speicher mentioned in commit dbab210f

    mentioned in commit dbab210f

  • Thiago Presa added 1 deleted label

    added 1 deleted label

  • The exception request is not approved yet so I'll not cherry-pick this one yet into RC3.

  • Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22301, will merge into 11-4-stable ready for 11.4 RC4

  • Cindy Pallares 🦉 removed 1 deleted label

    removed 1 deleted label

  • Robert Speicher mentioned in commit d64bc275

    mentioned in commit d64bc275

  • mentioned in issue #52756 (moved)

  • Please register or sign in to reply
    Loading