Skip to content
Snippets Groups Projects

Removes all the irrelevant code and columns that were migrated from the Project…

Merged Tiago Botelho requested to merge 50341-cleanup-useless-project-import-attributes into master

What does this MR do?

This MR focuses on cleaning up all the logic that was implemented in order to make the migration of the mirror logic from the project table over to the project_import_state table.

Architectural questions:

  • Should we keep the convenience methods in the Project and delegate them over to the ProjectImportState? Or should we always use project.import_state.jid instead of project.import_state_jid for example
  • Check the GithubImport and LegacyGithubImport logic since they both make use of Project#ensure_import_state which will be removed in this MR
  • Some of the queries could be better tuned now that all the columns were successfully migrated over to the ProjectImportState table, we should explore those improvements.

Reminders

  • The EE codebase still needs more cleanup than the CE one

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#50341 (closed)

Edited by Tiago Botelho

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading