Removes all the irrelevant code and columns that were migrated from the Project…
What does this MR do?
This MR focuses on cleaning up all the logic that was implemented in order to make the migration of the mirror logic from the project table over to the project_import_state table.
Architectural questions:
- Should we keep the convenience methods in the
Projectand delegate them over to theProjectImportState? Or should we always useproject.import_state.jidinstead ofproject.import_state_jidfor example - Check the
GithubImportandLegacyGithubImportlogic since they both make use ofProject#ensure_import_statewhich will be removed in this MR - Some of the queries could be better tuned now that all the columns were successfully migrated over to the
ProjectImportStatetable, we should explore those improvements.
Reminders
- The EE codebase still needs more cleanup than the CE one
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides
What are the relevant issue numbers?
Edited by Tiago Botelho