Skip to content

WIP: [Quality] Consolidate selector patterns & Add dynamic validation

Dan Davison requested to merge qa-consolidate-selector-pattern into master

What does this MR do?

1. implements https://gitlab.com/gitlab-org/gitlab-ce/issues/47287

this MR makes the different selector strategies uniform.

  • element :something
  • element :something_else, 'link_to something_path'

instead of using the .qa-* class, this change will implement https://gitlab.com/gitlab-org/gitlab-ce/issues/47287 and use the [data-qa-selector] strategy instead.

2. implements gitlab-qa#280 (closed) and adds dynamic validation on the click_element and visit methods

by specifying click_element :lnk_login, Page::Main::Login, the QA framework will traverse through the "required" elements and validate they are present before continuing with the test.

3. rename all elements to use a more uniform hungarian notation for UI elements.

  • lnk_test vs test_link
  • btn_test vs test_button
  • ...

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

FYI @gl-quality

/cc @rymai @meks

Edited by Dan Davison

Merge request reports