Skip to content

Feature flag to disable Hashed Storage migration when renaming a repository

Gabriel Mazetto requested to merge 50345-hashed-storage-feature-flag into master

What does this MR do?

Adds a feature flag to disable Hashed Storage migration when renaming a repository (and the Hashed Storage settings is turned on).

This is a temporary safe-feature in order to proceed with a rollout in gitlab-dot-com. See https://gitlab.com/gitlab-com/infrastructure/issues/4772

This also refactors Feature Flag test helpers, adds documentation and specs to it. The reason why this change was needed, is that disabled? actually calls enabled? with two parameters (key and nil), but the stub_feature_flags was mocking it with only one parameters. That means calling disabled? in a test would never returnt the expected results. The alternative was either add another mock to the two existing ones, or fix the behavior on the implementation.

What are the relevant issue numbers?

#50345 (closed) https://gitlab.com/gitlab-com/infrastructure/issues/4772

Does this MR meet the acceptance criteria?

Closes #50345 (closed)

Edited by Gabriel Mazetto

Merge request reports