Refactor AutocompleteController
What does this MR do?
This MR refactors AutocompleteController
according to the abstraction guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653.
Why was this MR needed?
This MR allows us to experiment with the proposal discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. AutocompleteController is simple enough (but not too simple) that we can apply these changes without the diff becoming too large to review.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Tests added for this feature/bug - Conforms to the code review guidelines
-
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/49653
TODO
-
Make sure all CE tests pass -
Set up EE MR since AutocompleteUsersFinder
has some EE specific code in it: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6840