Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs'
What does this MR do?
Replaces Sidekiq::Testing.inline!
with perform_enqueued_jobs
in specs.
Sidekiq::Testing.inline!
is a Sidekiq
method.
Using this method violates the Dependency inversion principle.
Are there points in the code the reviewer needs to double check?
No.
Why was this MR needed?
Technical debt.
Screenshots (if relevant)
No.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conforms to the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #22991 (closed)
Edited by blackst0ne